Skip to content

Tolerate read-only managed dependencies files #408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Feb 19, 2020
Merged

Tolerate read-only managed dependencies files #408

merged 8 commits into from
Feb 19, 2020

Conversation

@AnatoliB
Copy link
Contributor

@AnatoliB AnatoliB commented Feb 19, 2020

Resolves #400:

  • When updating the heartbeat (the timestamp on the .used file under a snapshot) fails because the file is read-only, log a warning but proceed.
  • Make sure the worker does not purge the currently used snapshot even if the heartbeat has not been updated for long time.

We'll need this fix in v2.x, v3.x/ps6, and v3.x/ps7 branches.

Francisco-Gamino
Francisco-Gamino approved these changes Feb 19, 2020
View reviewed changes
Copy link
Contributor

@Francisco-Gamino Francisco-Gamino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AnatoliB AnatoliB merged commit 66e681c into Azure:v3.x/ps6 Feb 19, 2020
@AnatoliB AnatoliB deleted the read-only-managed-deps-v3ps6 branch February 19, 2020 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Francisco-Gamino Francisco-Gamino Francisco-Gamino approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AnatoliB @Francisco-Gamino