Add sources subdirectory parameter to template #1154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Charles-Gagnon
requested review from
MaddyDev,
VasuBhog and
chlafreniere
as code owners
chlafreniere
approved these changes
Nov 27, 2024
MaddyDev
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ADO pipelines put the sources in a different folder, so the root Build.SourcesDirectory doesn't work. And since Build.SourcesDirectory can't be updated and template parameters need to be evaluated at compile-time (not runtime) this is the solution I came up with. Another option would have been to create a new runtime variable (e.g. SqlBindingsSourcesDirectory) - but I didn't see either one as being strictly better so went with this one since it's what I tried first.