Throw a more helpful error message for unsupported types #666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucyzhang929
requested review from
Charles-Gagnon,
MaddyDev,
VasuBhog and
chlafreniere
as code owners
Charles-Gagnon
approved these changes
Feb 7, 2023
src/SqlAsyncCollector.cs
Outdated
| { | ||
| foreach (string unsupportedType in UnsupportedTypes) | ||
| { | ||
| if (columns[property].StartsWith(unsupportedType, StringComparison.OrdinalIgnoreCase)) |
Contributor
There was a problem hiding this comment.
Is there a reason to use StartsWith instead of comparing the whole string?
Contributor
Author
There was a problem hiding this comment.
The column type also includes the size, for example text(10).
Contributor
There was a problem hiding this comment.
Can you have sizes for these types? I tried and it gave me an error
Contributor
Author
There was a problem hiding this comment.
Hm, the value I got while testing was text() so I thought there can be sizes. Maybe the column type returned will always be text(), ntext(), and image(). I'll double check.
Contributor
Author
There was a problem hiding this comment.
The (*) gets added on because of this line in the query
(*) and simplified the check.
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
MaddyDev
approved these changes
Feb 8, 2023
PBBlox
pushed a commit
to PBBlox/azure-functions-sql-extension
that referenced
this pull request
Apr 6, 2025
* throw custom error for unsupported types * add ntext & image to test + cleanup * fix powershell ordering * Update src/SqlAsyncCollector.cs Co-authored-by: Charles Gagnon <chgagnon@microsoft.com> * update column names * fix tests * simplify --------- Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #270