BatchSize -> MaxBatchSize #668
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Charles-Gagnon
requested review from
MaddyDev,
VasuBhog,
chlafreniere and
lucyzhang929
as code owners
lucyzhang929
approved these changes
Feb 8, 2023
Contributor
Author
|
Ok finally got the failing test - and fixed the issue causing it to hang instead of actually failing too! |
MaddyDev
approved these changes
Feb 10, 2023
PBBlox
pushed a commit
to PBBlox/azure-functions-sql-extension
that referenced
this pull request
Apr 6, 2025
* BatchSize -> MaxBatchSize * Add backwards compat support * updates * fix test * Fix one more
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Got some feedback recently about BatchSize being confusing since it's really the max batch size - the trigger will send as many changes as it has each time up to the max batch size specified. So updating the config override value to match.
Old value will still be read if the new value isn't specified for backwards compat support. I'll open a tracking issue for removing this for GA since removing it at that point should be ok.