Update SetupGuide_Python.md #672
Conversation
lucyzhang929
requested review from
Charles-Gagnon,
MaddyDev,
VasuBhog and
chlafreniere
as code owners
| If the `{name}` specified in the `getproducts-namenull/{name}` URL is "null", the query returns all rows for which the Name column is `NULL`. Otherwise, it returns all rows for which the value of the Name column matches the string passed in `{name}` | ||
| _TODO_ |
There was a problem hiding this comment.
Will be adding this sample in a follow up PR.
| #### Query String | ||
| _TODO_ | ||
| The input binding executes the `SELECT * FROM Products WHERE Cost = @Cost` query. The Parameters argument passes the `{cost}` specified in the URL that triggers the function, `getproducts/{cost}`, as the value of the `@Cost` parameter in the query. CommandType is set to `Text`, since the constructor argument of the binding is a raw query. |
There was a problem hiding this comment.
As I mentioned to Maddy in the other one - it'd be better I think to put these descriptions into the functions themselves and then just have this be the link to the function folder. That way people looking at the samples directly can benefit from the descriptions too.
| #### Array | ||
| _TODO_ | ||
| https://github.com/Azure/azure-functions-sql-extension/tree/main/samples/samples-python/AddProductsArray |
There was a problem hiding this comment.
| https://github.com/Azure/azure-functions-sql-extension/tree/main/samples/samples-python/AddProductsArray | |
| <https://github.com/Azure/azure-functions-sql-extension/tree/main/samples/samples-python/AddProductsArray> |
| #### Single Row | ||
| _TODO_ | ||
| https://github.com/Azure/azure-functions-sql-extension/tree/main/samples/samples-python/AddProduct |
There was a problem hiding this comment.
| https://github.com/Azure/azure-functions-sql-extension/tree/main/samples/samples-python/AddProduct | |
| <https://github.com/Azure/azure-functions-sql-extension/tree/main/samples/samples-python/AddProduct> |
| _TODO_ | ||
| In this case, the parameter value of the `@Name` parameter is an empty string. | ||
| https://github.com/Azure/azure-functions-sql-extension/tree/main/samples/samples-python/GetProductsNameEmpty |
There was a problem hiding this comment.
| https://github.com/Azure/azure-functions-sql-extension/tree/main/samples/samples-python/GetProductsNameEmpty | |
| <https://github.com/Azure/azure-functions-sql-extension/tree/main/samples/samples-python/GetProductsNameEmpty> |
| _TODO_ | ||
| The input binding executes the `SELECT * FROM Products WHERE Cost = @Cost` query. The Parameters argument passes the `{cost}` specified in the URL that triggers the function, `getproducts/{cost}`, as the value of the `@Cost` parameter in the query. CommandType is set to `Text`, since the constructor argument of the binding is a raw query. | ||
| https://github.com/Azure/azure-functions-sql-extension/tree/main/samples/samples-python/GetProducts |
There was a problem hiding this comment.
nit: One thing I just learned about is that for "proper" markdown raw links like this should be put in <>
https://www.markdownguide.org/basic-syntax#urls-and-email-addresses
Edit: Oh ok...I thought the batching was something I could do to group up suggestions but guess you have to do it. So if you want to combine all these into a single commit instead of having many separate small commits that's an option 😁
| https://github.com/Azure/azure-functions-sql-extension/tree/main/samples/samples-python/GetProducts | |
| <https://github.com/Azure/azure-functions-sql-extension/tree/main/samples/samples-python/GetProducts> |
There was a problem hiding this comment.
I would include something prior to the link however such as "Sample can be found here." (especially if we plan to just include links by themselves.
That would just be clear and concise. Also would not have to include the long links potentially.
There was a problem hiding this comment.
Yeah, I like that. I'd suggest naming the link though - e.g.
See the [GetProducts](...) sample
Although that sounds a bit incomplete to me...but I can't think of anything better myself so if you come up with anything feel free to throw it out as a suggestion and we can see which one we like the best.
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
|
Opened a new PR to address comments - closing this one. |
No description provided.