adding -Location parameter to get-azComputeResourceSku (#12408)

* adding warning when not using latest image version when creading vmss

* update to tabified file

* add missing bracket

* remove new lines from Get-Content call

* minor fixes

* using assert-true method

* removing some commmented out code

* align

* indent

* newline at the end

* Update ChangeLog.md

* add location parameter to get-azcomputeresourcesku

* add help file

* update changelog.md

* review update

* Update ChangeLog.md

* review fixes

* test commit

* undo test

Co-authored-by: Yabo Hu <yabhu@microsoft.com>
Co-authored-by: Yunchi Wang <54880216+wyunchi-ms@users.noreply.github.com>

Author: 3 people

src/Compute/Compute.Test/ScenarioTests/ResourceSkuTests.cs

@@ -30,5 +30,12 @@ public void TestGetResourceSku()
         {
             TestRunner.RunTestScript("Test-GetResourceSku");
         }
+
+        [Fact]
+        [Trait(Category.AcceptanceType, Category.CheckIn)]
+        public void TestGetResourceSkuByLocation()
+        {
+            TestRunner.RunTestScript("Test-GetResourceSkuByLocation");
+        }
     }
 }

src/Compute/Compute.Test/ScenarioTests/ResourceSkuTests.ps1

@@ -25,3 +25,13 @@ function Test-GetResourceSku
 	Assert-True { $output.Contains("virtualMachines"); }
 	Assert-True { $output.Contains("Zones"); }
 }
+
+<#
+.SYNOPSIS
+Test List Resource Skus by Location
+#>
+function Test-GetResourceSkuByLocation
+{
+	$skulist = Get-AzComputeResourceSku "westus" | where {$_.Locations -eq "eastus"};
+	Assert-True { $skulist.Count -eq 0; }
+}

src/Compute/Compute.Test/SessionRecords/Microsoft.Azure.Commands.Compute.Test.ScenarioTests.ResourceSkuTests/TestGetResourceSkuByLocation.json

@@ -22,6 +22,7 @@
 
 ## Version 4.2.1
 * Added warning when using `New-AzVmss` without "latest" image version
+* Added '-Location' as optional positional parameter to Get-AzComputeResourceSku cmdlet
 
 ## Version 4.2.0
 * Added SimulateEviction parameter to Set-AzVM and Set-AzVmssVM cmdlets.

src/Compute/Compute/ChangeLog.md

@@ -36,13 +36,29 @@ namespace Microsoft.Azure.Commands.Compute.Automation
     [OutputType(typeof(PSResourceSku))]
     public partial class GetAzureRmComputeResourceSku : ComputeAutomationBaseCmdlet
     {
+        [Parameter(
+            Mandatory = false, 
+            Position = 0, 
+            ValueFromPipelineByPropertyName = true)]
+        [ValidateNotNullOrEmpty]
+        [LocationCompleter("Microsoft.Compute/locations/publishers")]
+        public string Location { get; set; }
+
         public override void ExecuteCmdlet()
         {
             base.ExecuteCmdlet();
             ExecuteClientAction(() =>
             {
-
-                var result = ResourceSkusClient.List();
+                Microsoft.Rest.Azure.IPage<ResourceSku> result;
+                if (this.IsParameterBound(c => c.Location))
+                {
+                    string filter = String.Format("location eq '{0}'", this.Location);
+                    result = ResourceSkusClient.List(filter);
+                }
+                else
+                {
+                    result = ResourceSkusClient.List();
+                }
                 var resultList = result.ToList();
                 var nextPageLink = result.NextPageLink;
                 while (!string.IsNullOrEmpty(nextPageLink))

src/Compute/Compute/Generated/ResourceSku/ResourceSkuListMethod.cs

@@ -13,7 +13,7 @@ List all compute resource Skus
 ## SYNTAX
 
 ```
-Get-AzComputeResourceSku [-DefaultProfile <IAzureContextContainer>] [<CommonParameters>]
+Get-AzComputeResourceSku [[-Location] <String>] [-DefaultProfile <IAzureContextContainer>] [<CommonParameters>]
 ```
 
 ## DESCRIPTION
@@ -23,7 +23,7 @@ List all compute resource Skus
 
 ### Example 1
 ```
-PS C:\> PS C:\> Get-AzComputeResourceSku | where {$_.Locations.Contains("westus")};
+PS C:\> Get-AzComputeResourceSku "westus";
 ```
 
 List all compute resource skus in West US region
@@ -45,12 +45,27 @@ Accept pipeline input: False
 Accept wildcard characters: False
 ```
 
+### -Location
+Specifies a location of the available skus to list.
+
+```yaml
+Type: System.String
+Parameter Sets: (All)
+Aliases:
+
+Required: False
+Position: 0
+Default value: None
+Accept pipeline input: True (ByPropertyName)
+Accept wildcard characters: False
+```
+
 ### CommonParameters
 This cmdlet supports the common parameters: -Debug, -ErrorAction, -ErrorVariable, -InformationAction, -InformationVariable, -OutVariable, -OutBuffer, -PipelineVariable, -Verbose, -WarningAction, and -WarningVariable. For more information, see [about_CommonParameters](http://go.microsoft.com/fwlink/?LinkID=113216).
 
 ## INPUTS
 
-### None
+### System.String
 
 ## OUTPUTS