Get-AzWebApp By Resource Group Slow

[microalps]

Description

@Kotasudhakarreddy committed the following changes:

#12127
#17269

The first was merged the second was not accepted. The reason why the second was not accepted was

since Site & SiteConfig are separate API calls & Subscriptions can have 100's of Webapps - for performance reasons & good user experience purpose
~@panchagnula

The same can be applied to the first commit. Can we revert this PR?

Issue script & Debug output

Get-AzWebApp -ResourceGroupName $resourceGroup

Environment data

Name                           Value                                                                                                                                                                                                           
----                           -----                                                                                                                                                                                                           
PSVersion                      5.1.19041.1682                                                                                                                                                                                                  
PSEdition                      Desktop                                                                                                                                                                                                         
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}                                                                                                                                                                                         
BuildVersion                   10.0.19041.1682                                                                                                                                                                                                 
CLRVersion                     4.0.30319.42000                                                                                                                                                                                                 
WSManStackVersion              3.0                                                                                                                                                                                                             
PSRemotingProtocolVersion      2.3                                                                                                                                                                                                             
SerializationVersion           1.1.0.1

Module versions

ModuleType Version    Name                                ExportedCommands                                                                                                                                                                     
---------- -------    ----                                ----------------                                                                                                                                                                     
Script     2.7.6      Az.Accounts                         {Add-AzEnvironment, Clear-AzContext, Clear-AzDefault, Connect-AzAccount...}                                                                                                          
Script     2.4.0      Az.Resources                        {Add-AzADGroupMember, Export-AzResourceGroup, Get-AzADAppCredential, Get-AzADApplication...}                                                                                         
Script     2.11.1     Az.Websites                         {Add-AzWebAppAccessRestrictionRule, Add-AzWebAppTrafficRouting, Edit-AzWebAppBackupConfiguration, Enter-AzWebAppContainerPSSession...}

Error output

No response

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @antcp, @AzureAppServiceCLI.

Issue Details

---

Description

@Kotasudhakarreddy committed the following changes:

#12127
#17269

The first was merged the second was not accepted. The reason why the second was not accepted was

since Site & SiteConfig are separate API calls & Subscriptions can have 100's of Webapps - for performance reasons & good user experience purpose
~@panchagnula

The same can be applied to the first commit. Can we revert this PR?

Issue script & Debug output

Get-AzWebApp -ResourceGroupName $resourceGroup

Environment data

Name                           Value                                                                                                                                                                                                           
----                           -----                                                                                                                                                                                                           
PSVersion                      5.1.19041.1682                                                                                                                                                                                                  
PSEdition                      Desktop                                                                                                                                                                                                         
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}                                                                                                                                                                                         
BuildVersion                   10.0.19041.1682                                                                                                                                                                                                 
CLRVersion                     4.0.30319.42000                                                                                                                                                                                                 
WSManStackVersion              3.0                                                                                                                                                                                                             
PSRemotingProtocolVersion      2.3                                                                                                                                                                                                             
SerializationVersion           1.1.0.1

Module versions

ModuleType Version    Name                                ExportedCommands                                                                                                                                                                     
---------- -------    ----                                ----------------                                                                                                                                                                     
Script     2.7.6      Az.Accounts                         {Add-AzEnvironment, Clear-AzContext, Clear-AzDefault, Connect-AzAccount...}                                                                                                          
Script     2.4.0      Az.Resources                        {Add-AzADGroupMember, Export-AzResourceGroup, Get-AzADAppCredential, Get-AzADApplication...}                                                                                         
Script     2.11.1     Az.Websites                         {Add-AzWebAppAccessRestrictionRule, Add-AzWebAppTrafficRouting, Edit-AzWebAppBackupConfiguration, Enter-AzWebAppContainerPSSession...}

Error output

No response

Author:	microalps
Assignees:	-
Labels:	App Services, Service Attention, bug, customer-reported
Milestone:	-

[panchagnula]

@microalps what is the ask here? to not support Get-AzWebapp with RG or for the RG flavor don't return siteConfig?
The performance of this is expected to be slow for scenarios with large # of resources. This change was added as it was requested by a # of users, & reverting at this point would be a breaking change that cannot be unfortunately done.

[microalps]

The ask is the latter; I understand 100% that it is a breaking change at this point. It is for this reason I did not submit a PR because I doubted that would be accepted.
Or, make everyone happy and make this behavior opt-in/out on all flavors.
At the very least, document this behavior so people know to avoid this flavor. I am getting all (which, fyi, calls the API per RG) and filtering in PS.
Struggled with this unnecessarily and google led me to the latter PR which indicated this wasn't accepted so I couldn't understand why I was seeing these repetitive calls in Fiddler until I checked the source itself. I know these tools are for devs, but I didn't expect to have to reverse engineer.

[microalps]

@panchagnula FYI #11895 clearly foresaw this issue and suggested an explicit -IncludeSiteConfig flag. That would be the second option here, although for backward compatibility reasons the defaults may differ for different calls.

[panchagnula]

No plans to make any breaking changes at this time - once our APIs would support pagination - we will automatically make changes to the commands here.