Skip to content

add pr knowledge share doc #10442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wyunchi-ms merged 1 commit into from
Nov 3, 2019
Merged

add pr knowledge share doc #10442

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions documentation/internal/pull-request-review-knowledge-share.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
## PR Review Knowledge Share

### Dependency Assemlby Version Confliction
If one assembly has been referenced by more than one module, we should let Az.Accounts to handle the dependency.

**RED** flag
- Update assembly version for common Microsoft.Extensions.*
- Add new dependency assemlby for one module, the assembly may be referenced by other module already.
- Contains version update for dependency assembly in module other than Az.Accounts

### Resource ID **MUST** start with a slash
*Correct*: "/subscriptions/18bxxxxxx-4d70-8b1e-937660bde798/resourceGroups/MNC-PowerShell/providers/Microsoft.Network/virtualnetworks/Mesh1"

*Wrong*: "subscriptions/18bxxxxxx-92e4-4d70-8b1e-937660bde798/resourceGroups/MNC-PowerShell/providers/Microsoft.Network/virtualnetworks/Mesh1"