-
Notifications
You must be signed in to change notification settings - Fork 4.1k
Az.CognitiveServices - Update SDK to 7.0, Improve error message #10959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yangyuan
commented
Jan 22, 2020
...iveServices/CognitiveServices/CognitiveServicesAccount/CognitiveServicesAccountBaseCmdlet.cs
Outdated
Show resolved
Hide resolved
Collaborator
|
Hi @yangyuan , Your PR looks good to me, could you please format your code in this convention? this.CognitiveServicesClient.Accounts.Update(this.ResourceGroupName, |
markcowl
requested changes
Jan 28, 2020
...es/CognitiveServices/CognitiveServicesAccount/AddAzureCognitiveServicesAccountNetworkRule.cs
Outdated
Show resolved
Hide resolved
...CognitiveServices/CognitiveServicesAccount/RemoveAzureCognitiveServicesAccountNetworkRule.cs
Outdated
Show resolved
Hide resolved
...itiveServices/CognitiveServices/CognitiveServicesAccount/SetAzureCognitiveServicesAccount.cs
Outdated
Show resolved
Hide resolved
...nitiveServices/CognitiveServicesAccount/UpdateAzureCognitiveServicesAccountNetworkRuleSet.cs
Outdated
Show resolved
Hide resolved
Member
Author
|
@markcowl update the format as suggested :) |
Collaborator
|
/azp run |
Contributor
|
Pull request contains merge conflicts. |
Collaborator
VeryEarly
approved these changes
Feb 5, 2020
markcowl
approved these changes
Feb 11, 2020
dingmeng-xue
pushed a commit
to dingmeng-xue/azure-powershell
that referenced
this pull request
Mar 29, 2020
…_delete Az.CognitiveServices - Update SDK to 7.0, Improve error message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update SDK to 7.0
Improve error message when server responses empty body
Checklist
CONTRIBUTING.mdChangeLog.mdfile(s) has been updated:ChangeLog.mdfile can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md## Upcoming Releaseheader -- no new version header should be added