Skip to content

Conversation

@yangyuan
Copy link
Member

Description

Update SDK to 7.0
Improve error message when server responses empty body

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@VeryEarly VeryEarly self-assigned this Jan 22, 2020
@VeryEarly
Copy link
Collaborator

Hi @yangyuan ,

Your PR looks good to me, could you please format your code in this convention?
Just to improve the readability.

this.CognitiveServicesClient.Accounts.Update(this.ResourceGroupName,
this.Name,
new CognitiveServicesAccount()
{
Properties = properties
});

@yangyuan
Copy link
Member Author

yangyuan commented Feb 4, 2020

@markcowl update the format as suggested :)

@VeryEarly
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link
Contributor

Pull request contains merge conflicts.

@VeryEarly
Copy link
Collaborator

@markcowl update the format as suggested :)

Hi @yangyuan ,

github display my suggested format change in a different way :(

sent you the right one through teams, also please fix the conflicting files

@VeryEarly VeryEarly requested a review from markcowl February 5, 2020 01:36
@VeryEarly VeryEarly merged commit fba96af into Azure:master Feb 11, 2020
dingmeng-xue pushed a commit to dingmeng-xue/azure-powershell that referenced this pull request Mar 29, 2020
…_delete

Az.CognitiveServices - Update SDK to 7.0, Improve error message
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants