[IoT] Add support to manage devices in an Iot Hub. #10960
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anusapan
force-pushed
the
manage-device
branch
2 times, most recently
from
1362126 to
a881485
Compare
anusapan
force-pushed
the
manage-device
branch
from
a881485 to
0ab71e2
Compare
markcowl
previously requested changes
Jan 25, 2020
Member
markcowl
left a comment
markcowl
left a comment
There was a problem hiding this comment.
Is there a design review for these new cmdlets. There are some patterns here (like dynamic parameters) that are expressly discouraged. Also, the new libraries have some dependency issues that will need to be resolved.
src/IotHub/IotHub/IotHub/DataPlane/Models/PSDeviceCapabilities.cs
Outdated
Show resolved
Hide resolved
...eProvisioningServices/DeviceProvisioningServices.Test/DeviceProvisioningServices.Test.csproj
Outdated
Show resolved
Hide resolved
anusapan
force-pushed
the
manage-device
branch
2 times, most recently
from
dc687d7 to
e188ca9
Compare
anusapan
commented
Jan 28, 2020
Contributor
Author
anusapan
left a comment
anusapan
left a comment
There was a problem hiding this comment.
@markcowl Already submitted the review design https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/472
anusapan
force-pushed
the
manage-device
branch
from
e188ca9 to
1e4f384
Compare
anusapan
force-pushed
the
manage-device
branch
from
1e4f384 to
353d860
Compare
Contributor
Author
|
/azp run azure-powershell - powershell-core |
Contributor
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run azure-powershell - powershell-core |
Contributor
|
Azure Pipelines successfully started running 1 pipeline(s). |
…to manage-device
VeryEarly
requested changes
Feb 4, 2020
Collaborator
VeryEarly
left a comment
VeryEarly
left a comment
There was a problem hiding this comment.
I'm sorry to have you back and forth on this, can you please change the "DeviceName" back to "DeviceId" as I specified in the design.
tools/StaticAnalysis/Exceptions/Az.IotHub/MissingAssemblies.csv
Outdated
Show resolved
Hide resolved
VeryEarly
previously approved these changes
Feb 5, 2020
anusapan
force-pushed
the
manage-device
branch
from
6db1b81 to
8b51c1c
Compare
anusapan
force-pushed
the
manage-device
branch
from
8b51c1c to
82c2683
Compare
anusapan
force-pushed
the
manage-device
branch
from
234bbdf to
420a731
Compare
VeryEarly
approved these changes
Feb 11, 2020
dingmeng-xue
pushed a commit
to dingmeng-xue/azure-powershell
that referenced
this pull request
Mar 29, 2020
[IoT] Add support to manage devices in an Iot Hub.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These cmdlets support the device CRUD in an IotHub which is data-plane operations.
Required link for cmdlet review design.
Checklist
CONTRIBUTING.mdChangeLog.mdfile(s) has been updated:ChangeLog.mdfile can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md## Upcoming Releaseheader -- no new version header should be added