Skip to content

Aladdin generated examples for DataFactory, RecoveryServices, Sql, Websites #11819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dingmeng-xue merged 14 commits into from
May 9, 2020
Merged

Aladdin generated examples for DataFactory, RecoveryServices, Sql, Websites #11819

dingmeng-xue merged 14 commits into from
May 9, 2020

Conversation

@aladdindoc
Copy link
Contributor

@aladdindoc aladdindoc commented May 6, 2020

  • Add Aladdin crafted examples.

@adxsdkps
Copy link
Collaborator

adxsdkps commented May 6, 2020

Can one of the admins verify this patch?

mikefrobbins
mikefrobbins requested changes May 7, 2020
View reviewed changes
@aladdindoc aladdindoc force-pushed the AutogeneratedExamples05062020T153344Z branch 2 times, most recently from 6d9d63c to ebe5ca0 Compare May 7, 2020 16:16
aladdindoc
aladdindoc commented May 7, 2020
View reviewed changes
mikefrobbins
mikefrobbins previously approved these changes May 7, 2020
View reviewed changes
Copy link
Contributor

@mikefrobbins mikefrobbins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mikefrobbins
mikefrobbins previously approved these changes May 7, 2020
View reviewed changes
Copy link
Contributor

@mikefrobbins mikefrobbins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aladdindoc
Copy link
Contributor Author

aladdindoc commented May 8, 2020

#sign-off

dcaro
dcaro reviewed May 8, 2020
View reviewed changes
Copy link
Contributor

@dcaro dcaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The example for Get-AzRecoveryServiceBackupContainer shoud use SQLDatabase and MSSQL.

dcaro
dcaro previously approved these changes May 8, 2020
View reviewed changes
Copy link
Contributor

@dcaro dcaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dingmeng-xue dingmeng-xue added this to the S169 (2020-05-18) - Build milestone May 9, 2020
@dingmeng-xue
Copy link
Member

dingmeng-xue commented May 9, 2020

/azp run

@azure-pipelines
Copy link
Contributor

azure-pipelines bot commented May 9, 2020

Azure Pipelines successfully started running 3 pipeline(s).

@msJinLei
Copy link
Contributor

msJinLei commented May 9, 2020

/azp run

@azure-pipelines
Copy link
Contributor

azure-pipelines bot commented May 9, 2020

Azure Pipelines successfully started running 3 pipeline(s).

@msJinLei msJinLei force-pushed the AutogeneratedExamples05062020T153344Z branch from 123a67e to cbc2087 Compare May 9, 2020 06:43
kceiw and others added 11 commits May 9, 2020 16:51
@kceiw
Add new examples to DataFactory, RecoveryServices, Sql, Websites
6dbf744 
	- Add new examples to the following modules:
		DataFactory
		RecoveryServices
		Sql
		Websites
@aladdindoc
Improve the new example style
b698bab 
- Remove the parameter -Force.
- Remove extra space after switch parameters.
@mikefrobbins
Update New-AzDataFactoryV2LinkedServiceEncryptedCredential.md
8958e35
@mikefrobbins
Update Remove-AzDataFactoryV2IntegrationRuntimeNode.md
81c3c91
@mikefrobbins
Update Sync-AzDataFactoryV2IntegrationRuntimeCredential.md
2ba903a
@mikefrobbins
Update Get-AzRecoveryServicesBackupStatus.md
3841780
@mikefrobbins
Update Start-AzRecoveryServicesAsrTestFailoverCleanupJob.md
aa0245d
@mikefrobbins
Update New-AzRecoveryServicesAsrProtectableItem.md
618663d
@mikefrobbins
Update Reset-AzWebAppPublishingProfile.md
5eb37dd
@mikefrobbins
Update Get-AzSqlSyncAgentLinkedDatabase.md
93bdc54
@mikefrobbins
Update New-AzDataFactoryV2LinkedServiceEncryptedCredential.md
a6b3f42
@msJinLei msJinLei force-pushed the AutogeneratedExamples05062020T153344Z branch from cbc2087 to 818abc8 Compare May 9, 2020 09:02
@msJinLei
Copy link
Contributor

msJinLei commented May 9, 2020

/azp run

@azure-pipelines
Copy link
Contributor

azure-pipelines bot commented May 9, 2020

Azure Pipelines successfully started running 3 pipeline(s).

@msJinLei
Copy link
Contributor

msJinLei commented May 9, 2020

@aladdindoc I rebase your commits to the latest master and resolve a conflict. Please check whether the current codes are what you want.

@dingmeng-xue dingmeng-xue self-requested a review May 9, 2020 10:41
@dingmeng-xue dingmeng-xue merged commit 64fa5a0 into Azure:master May 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dingmeng-xue dingmeng-xue dingmeng-xue approved these changes

@dcaro dcaro dcaro left review comments

@mikefrobbins mikefrobbins mikefrobbins left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

S169 (2020-05-18) - Build

Development

Successfully merging this pull request may close these issues.

7 participants

@aladdindoc @adxsdkps @dingmeng-xue @msJinLei @dcaro @mikefrobbins @kceiw