Added new cmdlets for BillingAccounts, BillingProfiles, InvoiceSections and updated Invoicing cmdlet

[asarkar84]

Description

Added new cmdlets for BillingAccounts, BillingProfiles, InvoiceSections and updated Invoicing cmdlet
Deprecated few cmdlets which are no longer supported
Created following issue for the review: https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/647

Checklist

• I have read the Submitting Changes section of CONTRIBUTING.md
• The title of the PR is clear and informative
• The appropriate ChangeLog.md file(s) has been updated:
  • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
  • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
• The PR does not introduce breaking changes
• If applicable, the changes made in the PR have proper test coverage
• For public API changes to cmdlets:
  • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
  • the markdown help files have been regenerated using the commands listed here

[adxsdkps]

Can one of the admins verify this patch?

[VeryEarly]

breaking changes are not allowed in non-breaking change release, please add these deprecated logic back, keep deprecation attribute: https://github.com/Azure/azure-powershell/blob/master/documentation/breaking-changes/breaking-changes-attribute-help.md#when-there-is-no-replacement-cmdlet

[asarkar84]

breaking changes are not allowed in non-breaking change release, please add these deprecated logic back, keep deprecation attribute: https://github.com/Azure/azure-powershell/blob/master/documentation/breaking-changes/breaking-changes-attribute-help.md#when-there-is-no-replacement-cmdlet

In the current version of SDK, we are not supporting the Get-AzBillingPeriod and Get-AzEnrollmentAccount cmdlets. Users were consuming these to get the UsageDetails which is part of the Consumption cmdlets. Now Consumption cmdlets has alternate ways to get the usage without the Billing Period etc.
Please make this as part of the breaking change release.

[VeryEarly]

breaking changes are not allowed in non-breaking change release, please add these deprecated logic back, keep deprecation attribute: https://github.com/Azure/azure-powershell/blob/master/documentation/breaking-changes/breaking-changes-attribute-help.md#when-there-is-no-replacement-cmdlet

In the current version of SDK, we are not supporting the Get-AzBillingPeriod and Get-AzEnrollmentAccount cmdlets. Users were consuming these to get the UsageDetails which is part of the Consumption cmdlets. Now Consumption cmdlets has alternate ways to get the usage without the Billing Period etc.
Please make this as part of the breaking change release.

Hi @asarkar84 ,

Next breaking change release should be this September, do you mean you want this PR to go with it?

[asarkar84]

@VeryEarly I have added back the Get-AzBillingPeriod and Get-AzEnrollmentAccount cmdlets. Removed CmdletDeprecation attribute from Get-AzEnrollmentAccount since we will keep supporting it. Keeping CmdletDeprecation attribute in Get-AzBillingPeriod cmdlet since this should be depricated in the next versions.
Please take a look.

[asarkar84]

breaking changes are not allowed in non-breaking change release, please add these deprecated logic back, keep deprecation attribute: https://github.com/Azure/azure-powershell/blob/master/documentation/breaking-changes/breaking-changes-attribute-help.md#when-there-is-no-replacement-cmdlet

In the current version of SDK, we are not supporting the Get-AzBillingPeriod and Get-AzEnrollmentAccount cmdlets. Users were consuming these to get the UsageDetails which is part of the Consumption cmdlets. Now Consumption cmdlets has alternate ways to get the usage without the Billing Period etc.
Please make this as part of the breaking change release.

Hi @asarkar84 ,

Next breaking change release should be this September, do you mean you want this PR to go with it?

Please note that we have added the deprecated logic back, do we still need this to be part of the breaking change release? What is the exact breaking change release date?

[VeryEarly]

breaking changes are not allowed in non-breaking change release, please add these deprecated logic back, keep deprecation attribute: https://github.com/Azure/azure-powershell/blob/master/documentation/breaking-changes/breaking-changes-attribute-help.md#when-there-is-no-replacement-cmdlet

In the current version of SDK, we are not supporting the Get-AzBillingPeriod and Get-AzEnrollmentAccount cmdlets. Users were consuming these to get the UsageDetails which is part of the Consumption cmdlets. Now Consumption cmdlets has alternate ways to get the usage without the Billing Period etc.
Please make this as part of the breaking change release.

Hi @asarkar84 ,
Next breaking change release should be this September, do you mean you want this PR to go with it?

Please note that we have added the deprecated logic back, do we still need this to be part of the breaking change release? What is the exact breaking change release date?

Hi @asarkar84 ,

This PR contains new cmdlets only now, so no need to wait for the breaking change release.

Please resolve comment and static analysis issue and ti should be good to go.

[asarkar84]

breaking changes are not allowed in non-breaking change release, please add these deprecated logic back, keep deprecation attribute: https://github.com/Azure/azure-powershell/blob/master/documentation/breaking-changes/breaking-changes-attribute-help.md#when-there-is-no-replacement-cmdlet

In the current version of SDK, we are not supporting the Get-AzBillingPeriod and Get-AzEnrollmentAccount cmdlets. Users were consuming these to get the UsageDetails which is part of the Consumption cmdlets. Now Consumption cmdlets has alternate ways to get the usage without the Billing Period etc.
Please make this as part of the breaking change release.

Hi @asarkar84 ,
Next breaking change release should be this September, do you mean you want this PR to go with it?

Please note that we have added the deprecated logic back, do we still need this to be part of the breaking change release? What is the exact breaking change release date?

Hi @asarkar84 ,

This PR contains new cmdlets only now, so no need to wait for the breaking change release.

Please resolve comment and static analysis issue and ti should be good to go.

@VeryEarly I have fixed the security tests.

[asarkar84]

Hi @VeryEarly We have removed the properties DownloadUrlExpiry, Type and BillingPeriodNames from the response of Get-AzBillingInvoice cmdlet which may be considered as a breaking change. Please take a look.
We may wait till the next Breaking change release in September.

[asarkar84]

@VeryEarly Since we are very close to the October breaking change release, I would like to ensure that the below PR is good to go. Please take a look again and let me know if you expect me to take any action.

[VeryEarly]

/azp run

[azure-pipelines]

No pipelines are associated with this pull request.

[VeryEarly]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 3 pipeline(s).

[asarkar84]

@VeryEarly Please merge this PR if it looks good now.

[asarkar84]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 3 pipeline(s).