Skip to content

Conversation

@chenlei-yang
Copy link
Contributor

@chenlei-yang chenlei-yang commented Jul 15, 2020

Description

Add new verifiers to analyze the signature problem occurs when two parameter sets have some kind of contain relationship, there is one example in #10954. The reason why it causes problems is that if two parameter sets have the same mandatory parameters or one mandatory parameter can cover another one's parameter and both of them are not set as default, and when you use the parameter they both have, it may not know which parameter set to choose.
When doing this, I found a problem in the former code, this piece of code will cause the cmdlet parameter's missing. It's because it only gets properties but didn't get fields, and cause my new verifier works incorrectly, so I fix it.

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@chenlei-yang chenlei-yang requested review from cormacpayne and wyunchi-ms and removed request for cormacpayne July 15, 2020 09:35
@wyunchi-ms wyunchi-ms merged commit 7e06e43 into Azure:master Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants