-
Notifications
You must be signed in to change notification settings - Fork 4.1k
Minor version bump if module version is less than 1.0.0 #12533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Can one of the admins verify this patch? |
isra-fel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like we should update here, otherwise we have contradicting logic for preview bump up:
azure-powershell/tools/VersionController/Models/VersionBumper.cs
Lines 140 to 144 in 955423d
| // PATCH update for preview modules (0.x.x or x.x.x-preview) | |
| if (splitVersion[0] == 0 || _isPreview) | |
| { | |
| versionBump = Version.PATCH; | |
| } |
I have updated code. |
chenlei-yang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
isra-fel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Minor version bump if module version is less than 1.0.0
Checklist
CONTRIBUTING.mdChangeLog.mdfile(s) has been updated:ChangeLog.mdfile can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md## Upcoming Releaseheader -- no new version header should be added