Skip to content

Conversation

@dingmeng-xue
Copy link
Member

Description

Minor version bump if module version is less than 1.0.0

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@adxsdkps
Copy link
Collaborator

Can one of the admins verify this patch?

@dingmeng-xue dingmeng-xue added this to the S173 (2020-08-04) milestone Jul 30, 2020
Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like we should update here, otherwise we have contradicting logic for preview bump up:

// PATCH update for preview modules (0.x.x or x.x.x-preview)
if (splitVersion[0] == 0 || _isPreview)
{
versionBump = Version.PATCH;
}

@dingmeng-xue
Copy link
Member Author

dingmeng-xue commented Jul 30, 2020

I feel like we should update here, otherwise we have contradicting logic for preview bump up:

// PATCH update for preview modules (0.x.x or x.x.x-preview)
if (splitVersion[0] == 0 || _isPreview)
{
versionBump = Version.PATCH;
}

I have updated code.

Copy link
Contributor

@chenlei-yang chenlei-yang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@isra-fel isra-fel merged commit 4fb2d2b into Azure:release-2020-08-04 Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants