Skip to content

Conversation

@BethanyZhou
Copy link
Contributor

@BethanyZhou BethanyZhou commented Aug 4, 2020

Description

Common repo PR: Azure/azure-powershell-common#200

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@adxsdkps
Copy link
Collaborator

adxsdkps commented Aug 4, 2020

Can one of the admins verify this patch?

@BethanyZhou
Copy link
Contributor Author

Hi Yeming, could you please help me review this PR? There is another PR needs to be reviewed first, Azure/azure-powershell-common#200 . Thanks.

Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @BethanyZhou please see my inline comments.
Besides, PSAzureSubscriptionPolicy and the constructors of PSAzureSubscription need to be tested.
Thanks

@BethanyZhou
Copy link
Contributor Author

Updated codes and removed local feeds. Please take a look. Thanks!

Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very well!

@isra-fel isra-fel merged commit 65aded7 into Azure:master Aug 7, 2020
@BethanyZhou BethanyZhou deleted the bez/exposeSubscriptionPolicies branch December 8, 2021 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Get-AzSubscription should expose subscriptionPolicies and quotaId

3 participants