-
Notifications
You must be signed in to change notification settings - Fork 4.1k
Add PSAzureSubscriptionPolicy for PSAzureSubScription. #12569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PSAzureSubscriptionPolicy for PSAzureSubScription. #12569
Conversation
|
Can one of the admins verify this patch? |
|
Hi Yeming, could you please help me review this PR? There is another PR needs to be reviewed first, Azure/azure-powershell-common#200 . Thanks. |
isra-fel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @BethanyZhou please see my inline comments.
Besides, PSAzureSubscriptionPolicy and the constructors of PSAzureSubscription need to be tested.
Thanks
src/Accounts/Authentication.ResourceManager/Models/PSAzureSubscription.cs
Outdated
Show resolved
Hide resolved
|
Updated codes and removed local feeds. Please take a look. Thanks! |
isra-fel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very well!
Description
Common repo PR: Azure/azure-powershell-common#200
Checklist
CONTRIBUTING.mdChangeLog.mdfile(s) has been updated:ChangeLog.mdfile can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md## Upcoming Releaseheader -- no new version header should be added