Skip to content

Conversation

@isra-fel
Copy link
Member

@isra-fel isra-fel commented Aug 6, 2020

Description

Triggered a sign job to verify the fix https://dev.azure.com/azure-sdk/internal/_build/results?buildId=485521&view=results

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@adxsdkps
Copy link
Collaborator

adxsdkps commented Aug 6, 2020

Can one of the admins verify this patch?

Comment on lines +44 to +46
$NetCoreScopes = @('NetCore')
$AzureScopes = @('All', 'Latest', 'ServiceManagement', 'AzureStorage')
$StackScopes = @('All', 'Stack')
Copy link
Member Author

@isra-fel isra-fel Aug 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Root cause: .psm1 has its own scope. If these variables were defined in a .psm1 file, we cannot access them here, so Update-Netcore (line 52) was skipped.

@isra-fel isra-fel self-assigned this Aug 6, 2020
@VeryEarly VeryEarly merged commit eadbb6e into Azure:master Aug 6, 2020
@isra-fel isra-fel deleted the fix-psm1 branch September 19, 2020 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants