Skip to content

Conversation

@wonner
Copy link
Contributor

@wonner wonner commented Aug 10, 2020

Description

This change add pipeline, linked service, trigger, notebook management cmdlets. Here is the commandlet review PR:https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/694

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@adxsdkps
Copy link
Collaborator

Can one of the admins verify this patch?

@wonner wonner requested a review from idear1203 August 10, 2020 07:18
@isra-fel isra-fel self-assigned this Aug 10, 2020
@isra-fel
Copy link
Member

Please resolve the conflicts and make sure your PR can build. Thanks

@idear1203 idear1203 marked this pull request as draft August 12, 2020 07:29
@idear1203 idear1203 marked this pull request as ready for review August 12, 2020 07:31
Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. You may find "Export-AzSynapseNotebook Does not support ShouldProcess but the cmdlet verb Export indicates that it should." in the log of static analysis jobs. Per my understanding, Export-AzSynapseNotebook does not make change on Azure, so you are safe to suppress this error
  2. Please write test cases

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing the return type to string would affect InvokeAzureSynapsePipeline.cs, which was designed to return a PSCreateRunResponse

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a bug need to fix. In the next released package of Artifacts, the return type will be CreateRunResponse.

@idear1203
Copy link
Contributor

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@msJinLei
Copy link
Contributor

@wonner Please resolve the conflicts.

@msJinLei msJinLei merged commit a3a5e56 into Azure:master Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants