-
Notifications
You must be signed in to change notification settings - Fork 4.1k
[Synapse] Add pipeline, linked service, trigger, notebook management cmdlets #12616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Can one of the admins verify this patch? |
|
Please resolve the conflicts and make sure your PR can build. Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- You may find "Export-AzSynapseNotebook Does not support ShouldProcess but the cmdlet verb Export indicates that it should." in the log of static analysis jobs. Per my understanding,
Export-AzSynapseNotebookdoes not make change on Azure, so you are safe to suppress this error - Please write test cases
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing the return type to string would affect InvokeAzureSynapsePipeline.cs, which was designed to return a PSCreateRunResponse
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a bug need to fix. In the next released package of Artifacts, the return type will be CreateRunResponse.
This reverts commit 51a98ed5845dd0f99005927c4981c9b0bd7bc59d.
This reverts commit ad3fed743322596a7105c57b6bcaf9becec0df90.
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
@wonner Please resolve the conflicts. |
Description
This change add pipeline, linked service, trigger, notebook management cmdlets. Here is the commandlet review PR:https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/694
Checklist
CONTRIBUTING.mdChangeLog.mdfile(s) has been updated:ChangeLog.mdfile can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md## Upcoming Releaseheader -- no new version header should be added