Skip to content

Conversation

@dingmeng-xue
Copy link
Member

Description

TargetModule can be set by user to just build and publish one module and its dependency Az.Accounts. For instance

dotnet msbuild build.proj /t:"Build;Publish" /p:"Configuration=Release;NuGetKey=12345;TargetModule=Compute"

It cannot support the array of modules because existing code in publish has limitation and assumes Az always needs to be published. I check if Az is required according to number of module is built. If it is more than 2, it means user doesn't use TargetModule property. For long term, we need to find a smart way to check if Az needs to be published according to the content in artifact folder only.

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@adxsdkps
Copy link
Collaborator

Can one of the admins verify this patch?

@dingmeng-xue
Copy link
Member Author

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).


foreach (var module in moduleNames)
{
foreach (var pair in mappingsDictionary)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest to use mappingDictionary.ContainsKey($"src/{module}/")

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

@dingmeng-xue dingmeng-xue merged commit b58fdb6 into Azure:master Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants