Skip to content

Conversation

@Xynoclafe
Copy link
Contributor

@Xynoclafe Xynoclafe commented Aug 19, 2020

…esourceGroupDeploymentOperation

Description

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@Xynoclafe Xynoclafe requested a review from filizt August 19, 2020 19:54
@adxsdkps
Copy link
Collaborator

Can one of the admins verify this patch?

filizt
filizt previously approved these changes Aug 19, 2020
Copy link
Contributor

@filizt filizt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Put the changelog item on the top.
@msJinLei msJinLei merged commit 4272983 into Azure:master Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants