Skip to content

Add null check in ConditionVersion of Set-AzRoleAssignmenr #12829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 3, 2020
Merged

Add null check in ConditionVersion of Set-AzRoleAssignmenr #12829

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f3c0cb5
add missing null check
dagoroz Sep 1, 2020
4224010
update docs
dagoroz Sep 1, 2020
286b58a
Remove old TODO
dagoroz Sep 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Resources/Resources/ChangeLog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
- Additional information about change #1
-->
## Upcoming Release
* Added missing check for Set-AzRoleAssignment
* Added breaking change attribute to `SubscriptionId` parameter of `Get-AzResourceGroupDeploymentOperation`
* Updated ARM template What-If cmdlets to show "Ignore" resource changes last
* Fixed secure and array parameter serialization issues for deployment cmdlets [#12773]
Expand Down
4 changes: 2 additions & 2 deletions src/Resources/Resources/RoleAssignments/SetAzureRoleAssignmentCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,8 +112,8 @@ public override void ExecuteCmdlet()
}

// If ConditionVersion is changed, validate it's in the allowed values
var oldConditionVersion = double.Parse(InputObject.ConditionVersion);
var newConditionVersion = double.Parse(fetchedRole.ConditionVersion);
var oldConditionVersion = double.Parse(InputObject.ConditionVersion ?? "0.0");
var newConditionVersion = double.Parse(fetchedRole.ConditionVersion ?? "2.0");

// A condition version can change but currently we don't support downgrading to 1.0
// we only verify the change if it's a downgrade
Expand Down