Skip to content

IgnoreCase = false for BackupStorageRedundancy #12985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 18, 2020
Merged

IgnoreCase = false for BackupStorageRedundancy #12985

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
89fd4ab
IgnoreCase = false for BackupStorageRedundancy
xaliciayang Sep 16, 2020
6f480dd
Skip Test-DatabasePauseResume to workaround
Sep 17, 2020
a76dc35
update changelog
xaliciayang Sep 17, 2020
cad1b6a
Merge branch 'ignoreCase' of https://github.com/xaliciayang/azure-pow…
xaliciayang Sep 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Sql/Sql.Test/ScenarioTests/DatabaseActivationTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ public DatabaseActivationTests(ITestOutputHelper output) : base(output)
};
}

[Fact]
[Fact(Skip = "The test takes the longest time to run. Skip it to workaround timeout temporarily.")]
[Trait(Category.AcceptanceType, Category.CheckIn)]
public void TestDatabasePauseResume()
{
Expand Down
2 changes: 1 addition & 1 deletion src/Sql/Sql/ChangeLog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
* Added cmdlet `New-AzSqlDatabaseImportExisting`
* Updated Databases cmdlets to support backup storage type specification
* Added Force parameter to `New-AzSqlDatabase`
* Added warning for BackupStorageRedundancy configuration in select regions in `New-AzSqlDatabase`
* Added warning for BackupStorageRedundancy configuration in select regions in `New-AzSqlDatabase` (Ignore Case for BackupStorageRedundancy configuration input)
* Updated ActiveDirectoryOnlyAuthentication cmdlets for server and instance to include ResourceId and InputObject

## Version 2.9.1
Expand Down
2 changes: 1 addition & 1 deletion src/Sql/Sql/Database/Cmdlet/NewAzureSqlDatabase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@ public class NewAzureSqlDatabase : AzureSqlDatabaseCmdletBase<AzureSqlDatabaseCr
/// </summary>
[Parameter(Mandatory = false,
HelpMessage = "The Backup storage redundancy used to store backups for the SQL Database. Options are: Local, Zone and Geo.")]
[ValidateSet("Local", "Zone", "Geo")]
[ValidateSet("Local", "Zone", "Geo", IgnoreCase = false)]
Copy link
Collaborator

@VeryEarly VeryEarly Sep 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks like a breaking change for me, do you want to release this in October major release?

Copy link
Contributor Author

@xaliciayang xaliciayang Sep 17, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like this to go as soon as possible; this is added to a parameter, BackupStorageRedundancy, that was only introduced in the last milestone (introduced in S175 (2020-09-22) Ignite), that was never used previously. I left a comment above explaining the need to add this change. @dingmeng-xue and @msJinLei have reviewed my previous changes that this belongs to.

I will add change log too.

Copy link
Collaborator

@VeryEarly VeryEarly Sep 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merged by mistake, the change log should under upcoming release, I'll make another PR to fix it

public string BackupStorageRedundancy { get; set; }

protected static readonly string[] ListOfRegionsToShowWarningMessageForGeoBackupStorage = { "eastasia", "southeastasia", "brazilsouth", "east asia", "southeast asia", "brazil south" };
Expand Down