Skip to content

Conversation

@stuartko
Copy link
Contributor

Description

Adds new cmdlets for managing Template Specs:

  • Get-AzTemplateSpec
  • New-AzTemplateSpec
  • Set-AzTemplateSpec
  • Export-AzTemplateSpec
  • Remove-AzTemplateSpec

Also adds support for deploying Template Specs via the existing deployment cmdlets. Cmdlets underwent extensive design reviews and discussions, and have been used by customers for the past ~2 months under a private preview release.

The Template Specs service remains in private preview but will enter Public Preview in October.

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • PR is "Adding Cmdlets for Template Specs (Private Preview) # 635"
    • the markdown help files have been regenerated using the commands listed here

stuartko and others added 30 commits May 13, 2020 17:34
@VeryEarly VeryEarly self-assigned this Sep 29, 2020
Copy link
Collaborator

@VeryEarly VeryEarly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add supportshould process to export cmdlet

@VeryEarly
Copy link
Collaborator

is there API version changes involved in this SDK upgrade? If so, please re-record test cases

@stuartko
Copy link
Contributor Author

please add supportshould process to export cmdlet

shouldprocess has now been added to all applicable cmdlets.

is there API version changes involved in this SDK upgrade? If so, please re-record test cases

Not outside of the newly introduced cmdlets/template specs client. We should be good here.

FYI: I see that some tests are failing, but they look to be completely unrelated to these changes. I presume these are failing across the latest master?

@stuartko
Copy link
Contributor Author

stuartko commented Oct 2, 2020

@VeryEarly : Are there any further actions needed before this is merged?

@stuartko stuartko requested a review from VeryEarly October 2, 2020 00:19
@VeryEarly
Copy link
Collaborator

@VeryEarly : Are there any further actions needed before this is merged?

those failed test cases have referenced get-azresource which has API upgrade.

This unnecessary reference was caused by bad test implementation, need help from peering team do the fix.

@stuartko
Copy link
Contributor Author

This unnecessary reference was caused by bad test implementation, need help from peering team do the fix.

Will this block the merge until it is fixed? Who is responsible for following up? Do we need to do anything further from our side?

@VeryEarly
Copy link
Collaborator

This unnecessary reference was caused by bad test implementation, need help from peering team do the fix.

Will this block the merge until it is fixed? Who is responsible for following up? Do we need to do anything further from our side?

We have some work around if developer from peering team was not managed to fix this issue. Let's wait for their response first.
Meanwhile please resolve merge conflicts.

@VeryEarly
Copy link
Collaborator

Hi @stuartko ,

Please take latest changes from master branch, thanks.

@VeryEarly
Copy link
Collaborator

/azp run azure-powershell - windows-powershell

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants