Skip to content

Fix a output of HostedSubnet under virtual router (#13102) #13185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
VeryEarly merged 5 commits into from
Oct 14, 2020
Merged

Fix a output of HostedSubnet under virtual router (#13102) #13185

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0d18266
Fix a output of HostedSubnet under virtual router (#13102)
litchiyangMSFT Oct 9, 2020
c597306
Merge branch 'master' into network-july
isra-fel Oct 12, 2020
d15aee1
suppress breaking change warning
isra-fel Oct 13, 2020
68a230e
Update ChangeLog.md
VeryEarly Oct 13, 2020
f4cc694
Merge branch 'master' into network-july
VeryEarly Oct 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Network/Network/ChangeLog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
--->

## Upcoming Release
* [Breaking Change] Removed parameter `HostedSubnet` and add `Subnet` instead
* Added new cmdlets for Virtual Router Peer Routes
- `Get-AzVirtualRouterPeerLearnedRoute`
- `Get-AzVirtualRouterPeerAdvertisedRoute`
Expand Down
2 changes: 1 addition & 1 deletion src/Network/Network/Generated/Models/PSHubIpConfiguration.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ namespace Microsoft.Azure.Commands.Network.Models
public partial class PSHubIpConfiguration : PSChildResource
{
[Ps1Xml(Target = ViewControl.Table)]
public string HostedSubnet { get; set; }
public PSSubnet Subnet { get; set; }
[Ps1Xml(Target = ViewControl.Table)]
public string ProvisioningState { get; set; }
}
Expand Down
2 changes: 1 addition & 1 deletion src/Network/Network/Generated/Models/PSVirtualRouter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ public PSVirtualRouter(PSVirtualHub virtualHub)
this.ResourceGuid = virtualHub.ResourceGuid;
this.Type = virtualHub.Type;
var ipconfig = virtualHub.IpConfigurations.FirstOrDefault<PSHubIpConfiguration>();
this.HostedSubnet = ipconfig.Id;
this.HostedSubnet = ipconfig.Subnet.Id;
this.VirtualRouterAsn = virtualHub.VirtualRouterAsn;
this.VirtualRouterIps = virtualHub.VirtualRouterIps;
this.ProvisioningState = virtualHub.ProvisioningState;
Expand Down
1 change: 1 addition & 0 deletions tools/StaticAnalysis/Exceptions/Az.Network/BreakingChangeIssues.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -585,3 +585,4 @@
"Microsoft.Azure.PowerShell.Cmdlets.Network.dll","Microsoft.Azure.Commands.Network.RemoveAzureVirtualRouterCommand","Remove-AzVirtualRouter","0","3010","The property 'HostedGateway' of type 'Microsoft.Azure.Commands.Network.Models.PSVirtualRouter' has been removed.","Add the property 'HostedGateway' back to type 'Microsoft.Azure.Commands.Network.Models.PSVirtualRouter'."
"Microsoft.Azure.PowerShell.Cmdlets.Network.dll","Microsoft.Azure.Commands.Network.RemoveAzureVirtualRouterCommand","Remove-AzVirtualRouter","0","3010","The property 'HostedGatewayText' of type 'Microsoft.Azure.Commands.Network.Models.PSVirtualRouter' has been removed.","Add the property 'HostedGatewayText' back to type 'Microsoft.Azure.Commands.Network.Models.PSVirtualRouter'."
"Microsoft.Azure.PowerShell.Cmdlets.Network.dll","Microsoft.Azure.Commands.Network.GetAzureRmVirtualRouterPeer","Get-AzVirtualRouterPeer","0","3010","The property 'Type' of type 'Microsoft.Azure.Commands.Network.Models.PSVirtualRouterPeer' has been removed.","Add the property 'Type' back to type 'Microsoft.Azure.Commands.Network.Models.PSVirtualRouterPeer'."
"Microsoft.Azure.PowerShell.Cmdlets.Network.dll","Microsoft.Azure.Commands.Network.NewAzureRmExpressRouteGatewayCommand","New-AzExpressRouteGateway","0","3010","The property 'HostedSubnet' of type 'Microsoft.Azure.Commands.Network.Models.PSHubIpConfiguration' has been removed.","Add the property 'HostedSubnet' back to type 'Microsoft.Azure.Commands.Network.Models.PSHubIpConfiguration'."