Skip to content

Conversation

@BethanyZhou
Copy link
Contributor

@BethanyZhou BethanyZhou commented Oct 15, 2020

Description

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@BethanyZhou BethanyZhou force-pushed the deprecateDisableSoftDelete branch from 1911feb to b91baf7 Compare October 15, 2020 05:04
Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have considered that we don't have to keep -EnableSoftDelete in the update cmdlet.
We also don't have to add notes in help docs, because user can get the info in changelog.
So I'll just merge the PR.
Thanks

@isra-fel isra-fel merged commit d8212ae into Azure:master Oct 16, 2020
@BethanyZhou BethanyZhou deleted the deprecateDisableSoftDelete branch December 8, 2021 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants