Add MSAL support for Az.Accounts #13225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

erich-wang merged 24 commits into master from erich/msal-azure-identity

Oct 20, 2020

Member

erich-wang commented Oct 15, 2020

Description

Checklist

I have read the Submitting Changes section of CONTRIBUTING.md
The title of the PR is clear and informative
The appropriate ChangeLog.md file(s) has been updated:
- For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
- A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
The PR does not introduce breaking changes
If applicable, the changes made in the PR have proper test coverage
For public API changes to cmdlets:
- a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
- the markdown help files have been regenerated using the commands listed here

erich-wang and others added 12 commits

September 17, 2020 17:19


          Add MSAL support based on Azure.Identity

55bac5e


          temp fix for adfs

1c53797


          fix cache

f64c537


          code refactoring

c9f33ac


          code refactoring

a125a8f


          add Azure.Identity local package

62b6fe3


          update test cases


          Merge branch 'feature/msal-identity' into erich/msal-azure-identity

6e233e3


          temporarily fix static analysis errors for eng bits

82e54a5


          fix spn+cert flow

d63a783


          fix msal cache helper

ca4b2c8


          code refactoring

5dfef5e

azuresdkci added the needs-review label

erich-wang added 2 commits

October 15, 2020 15:12


          merge with master

d34c93c


          update Azure.Identity to 1.4.0-beta.1

b33adda

erich-wang commented

View reviewed changes

src/Accounts/Accounts/Account/ConnectAzureRmAccount.cs Show resolved Hide resolved

erich-wang commented

View reviewed changes

src/Accounts/Accounts/AutoSave/EnableAzureRmContextAutosave.cs Show resolved Hide resolved

erich-wang commented

View reviewed changes

src/Accounts/Accounts/AutoSave/EnableAzureRmContextAutosave.cs Outdated Show resolved Hide resolved

erich-wang commented

View reviewed changes

src/Accounts/Accounts/AutoSave/GetAzureRmContextAutosaveSetting.cs Outdated Show resolved Hide resolved

erich-wang commented

View reviewed changes

src/Accounts/Accounts/Az.Accounts.psd1 Outdated Show resolved Hide resolved

erich-wang commented

View reviewed changes

src/Accounts/Accounts/Az.Accounts.psd1 Outdated Show resolved Hide resolved

erich-wang commented

View reviewed changes

src/Accounts/Accounts/Context/ClearAzureRmContext.cs Show resolved Hide resolved

erich-wang commented

View reviewed changes

src/Accounts/Authentication.ResourceManager/AzureRmProfile.cs Outdated Show resolved Hide resolved

erich-wang commented

View reviewed changes

src/Accounts/Authentication/Factories/AuthenticationFactory.cs Outdated Show resolved Hide resolved

erich-wang commented

View reviewed changes

src/Accounts/Authentication/Factories/AuthenticatorBuilder.cs Outdated Show resolved Hide resolved

erich-wang commented

View reviewed changes

src/Accounts/Authenticators/DeviceCodeAuthenticator.cs Outdated Show resolved Hide resolved

erich-wang added 4 commits

October 18, 2020 23:22


          refacotring code per review comments

420ff0d


          fix build error

7ed4ab4


          fix test case errors

a597a94


          fix build error on MacOS

709ac43

erich-wang added 3 commits

October 19, 2020 16:21


          update common assemblies

5c92429


          update static analysis

285b609


          update test cases

e95ed5a

erich-wang marked this pull request as ready for review

October 19, 2020 15:41

erich-wang assigned isra-fel


          fix typo

114b57a

isra-fel mentioned this pull request

[KeyVault] Managed HSM #13259

Merged

10 tasks

Member

isra-fel commented Oct 20, 2020

LGTM

erich-wang added 2 commits

October 20, 2020 13:27


          update test cases

d65ce35


          Merge branch 'erich/msal-azure-identity' of https://github.com/Azure/…

070ab19

…azure-powershell into erich/msal-azure-identity

Member Author

erich-wang commented Oct 20, 2020

There's one test case failure because of common assemblies, force merge to save time.

erich-wang merged commit 769fbbb into master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels