Skip to content

Conversation

@BethanyZhou
Copy link
Contributor

@BethanyZhou BethanyZhou commented Oct 20, 2020

Description

Before: Always consume the newest build artifacts of 'azure-powershell - sign'

Now: Get the build artifacts by pipeline id.

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@BethanyZhou BethanyZhou force-pushed the bez/smokeTestPipeline branch from b9fbc87 to 1713b02 Compare October 20, 2020 06:53
@msJinLei
Copy link
Contributor

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@isra-fel
Copy link
Member

@BethanyZhou is this PR ready for review and shall I review it?

@BethanyZhou
Copy link
Contributor Author

Yes, please help to review it.

@isra-fel isra-fel self-assigned this Oct 22, 2020
Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you trigger a test run?

@BethanyZhou
Copy link
Contributor Author

/azp run azure-powershell - powershell-core

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@BethanyZhou BethanyZhou force-pushed the bez/smokeTestPipeline branch 2 times, most recently from 0c3743e to b2644a1 Compare October 28, 2020 03:13
@BethanyZhou BethanyZhou force-pushed the bez/smokeTestPipeline branch from b2644a1 to a3eeacc Compare October 28, 2020 04:07
@BethanyZhou
Copy link
Contributor Author

A running example about getting the latest artifacts is: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=593944&view=results
Get the specified artifacts: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=599860&view=results
Please take a look, thanks.

@BethanyZhou
Copy link
Contributor Author

Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my inline comments. Thanks

Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@isra-fel isra-fel merged commit 5ad35b4 into master Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants