Skip to content

Make arguments -MinScaleUnits and -MaxScaleUnits optional in Set-AzExpressRouteGateway #13428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
isra-fel merged 3 commits into from
Nov 9, 2020
Merged

Make arguments -MinScaleUnits and -MaxScaleUnits optional in Set-AzExpressRouteGateway #13428

isra-fel merged 3 commits into from
Nov 9, 2020

Conversation

@nimaller
Copy link
Contributor

@nimaller nimaller commented Nov 5, 2020 •
edited
Loading

Description

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@nimaller nimaller changed the title Update express route gateway Make arguments -MinScaleUnits and -MaxScaleUnits optional in Set-AzExpressRouteGateway Nov 5, 2020
isra-fel
isra-fel approved these changes Nov 6, 2020
View reviewed changes
Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@isra-fel isra-fel assigned isra-fel and unassigned nimaller Nov 6, 2020
@isra-fel isra-fel merged commit f923b20 into Azure:master Nov 9, 2020
@isra-fel isra-fel mentioned this pull request Nov 9, 2020
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@isra-fel isra-fel isra-fel approved these changes

@MikhailTryakhov MikhailTryakhov Awaiting requested review from MikhailTryakhov

Assignees

@isra-fel isra-fel

Labels

Waiting for CI :shipit:

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nimaller @isra-fel @azuresdkci