[CloudService] Init for CloudService #13571
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into wyunchi/CloudService
…-powershell into wyunchi/CloudService
…-powershell into wyunchi/CloudService
Updating to change apiversion to 2020-06-01
Contributor
|
@wyunchi-ms Please fix the credential scan error |
…into shared/CloudService
…powershell into shared/CloudService
msJinLei
suggested changes
Nov 30, 2020
| else | ||
| { | ||
| $storageEndpoint = "https://core.windows.net" | ||
| $protectedSetting = '<?xml version="1.0" encoding="UTF-8"?><PrivateConfig xmlns="http://schemas.microsoft.com/ServiceHosting/2010/10/DiagnosticsConfiguration"><StorageAccount endpoint="' + $storageEndpoint + '" key="' + $StorageAccountKey + '" name="' + $storageAccountName + '"/></PrivateConfig>' |
Contributor
There was a problem hiding this comment.
It is better to use "${variable}" in the string.
Contributor
Author
There was a problem hiding this comment.
There will be many escape char for " in xml.
src/CloudService/custom/New-AzCloudServiceRemoteDesktopExtensionObject.ps1
Outdated
Show resolved
Hide resolved
msJinLei
suggested changes
Nov 30, 2020
Contributor
msJinLei
left a comment
msJinLei
left a comment
There was a problem hiding this comment.
Please check whether the parameters' descriptions are well generated in cmdlet help files.
dolauli
reviewed
Dec 1, 2020
dolauli
reviewed
Dec 1, 2020
src/CloudService/custom/New-AzCloudServiceLoadBalancerConfigurationObject.ps1
Show resolved
Hide resolved
msJinLei
suggested changes
Dec 1, 2020
msJinLei
approved these changes
Dec 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
CONTRIBUTING.mdChangeLog.mdfile(s) has been updated:ChangeLog.mdfile can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md## Upcoming Releaseheader -- no new version header should be added