Skip to content

Conversation

@sredman
Copy link
Contributor

@sredman sredman commented Dec 16, 2020

Description

#12899 introduced a bug which caused the Status and StatusMessage fields of the Get-AzSqlDatabaseImportExportStatus calls to be wrong:

  • The value which is supposed to be in the StatusMessage field was in the Status field
  • The value which is supposed to be in the Status field was missing completely

This does not line up with our documentation and was causing significant confusion.

For instance, in our documentation, we have:

Get-AzSqlDatabaseImportExportStatus -OperationStatusLink "https://management.contoso.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/resource01/providers/Microsoft.Sql/servers/server01/databases/database01/importExportOperationResults/00000000-000-0000-0000-000000000000?api-version=2014-04-01"
OperationStatusLink :
ErrorMessage :
LastModifiedTime : 4/15/2016 10:16:14 PM
QueuedTime : 4/15/2016 10:16:13 PM
StatusMessage : Running, Progress = 5.00 %
Status : InProgress

However, with releases after 2.10.0, we would actually return

Get-AzSqlDatabaseImportExportStatus -OperationStatusLink "https://management.contoso.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/resource01/providers/Microsoft.Sql/servers/server01/databases/database01/importExportOperationResults/00000000-000-0000-0000-000000000000?api-version=2014-04-01"
OperationStatusLink :
ErrorMessage :
LastModifiedTime : 4/15/2016 10:16:14 PM
QueuedTime : 4/15/2016 10:16:13 PM
StatusMessage :
Status : Running, Progress = 5.00 %

I have re-activated some tests which were removed in the previous PR, though most of the test seems to be hitting an SDK issue (see in-code comments). I have opened a work item on the Import/Export service team's backlog to address this SDK issue.

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • This PR does not make public API changes
      • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
        • {Please put the link here}
      • the markdown help files have been regenerated using the commands listed here

@sredman sredman marked this pull request as ready for review December 16, 2020 01:05
pixia
pixia previously approved these changes Dec 16, 2020
pixia
pixia previously approved these changes Dec 17, 2020
@wyunchi-ms wyunchi-ms merged commit c9fcb7e into Azure:master Dec 17, 2020
@sredman sredman linked an issue Jan 5, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inconsistent status returned by Get-AzSqlDatabaseImportExportStatus

4 participants