Skip to content

Conversation

@Brandon411
Copy link
Contributor

@Brandon411 Brandon411 commented Oct 4, 2022

Description

Design review: https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/1252

Adding new cmdlets:

  • Get-AzEventGridPartnerRegistration
  • Get-AzEventGridPartnerConfiguration
  • Get-AzEventGridVerifiedPartner
  • Get-AzEventGridPartnerNamespace
  • Get-AzEventGridChannel
  • Get-AzEventGridPartnerNamespaceKey
  • Get-AzEventGridPartnerTopic
  • Get-AzEventGridPartnerTopicEventSubscription
  • New-AzEventGridPartnerRegistration
  • New-AzEventGridPartnerConfiguration
  • New-AzEventGridPartnerNamespace
  • New-AzEventGridPartnerTopic
  • New-AzEventGridChannel
  • New-AzEventGridPartnerTopicEventSubscription
  • Update-AzEventGridPartnerConfiguration
  • Update-AzEventGridChannel
  • Update-AzEventGridPartnerTopic
  • Update-AzEventGridPartnerTopicEventSubscription
  • Remove-AzEventGridPartnerRegistration
  • Remove-AzEventGridPartnerConfiguration
  • Remove-AzEventGridPartnerNamespace
  • Remove-AzEventGridChannel
  • Remove-AzEventGridPartnerTopic
  • Remove-AzEventGridPartnerTopicEventSubscription
  • Grant-AzEventGridPartnerConfiguration
  • Enable-AzEventGridPartnerTopic
  • Revoke-AzEventGridPartnerConfiguration
  • New-AzEventGridPartnerNamespaceKey

Checklist

  • SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
  • SHOULD make the title of PR clear and informative, and in the present imperative tense.
  • SHOULD update ChangeLog.md file(s) appropriately
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
    • Create new module from scratch
    • Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
    • Create new resource type which name doesn't use module name as prefix
    • Have design question before implementation
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT introduce breaking changes in Az minor release except preview version.
  • SHOULD NOT adjust version of module manually in pull request

@Brandon411 Brandon411 changed the title Brandonneff/eventgrid 06 15 2022 [Az.EventGrid] Add partner features from 2022-06-15 API Oct 4, 2022
@Brandon411 Brandon411 force-pushed the brandonneff/eventgrid-06-15-2022 branch from f739f15 to b41249a Compare October 4, 2022 07:40
@Brandon411 Brandon411 force-pushed the brandonneff/eventgrid-06-15-2022 branch from b41249a to d516e1b Compare October 4, 2022 07:48
@Brandon411 Brandon411 marked this pull request as ready for review October 6, 2022 07:25
@Brandon411 Brandon411 force-pushed the brandonneff/eventgrid-06-15-2022 branch from 3296047 to 273ec73 Compare October 6, 2022 07:48
@wyunchi-ms
Copy link
Contributor

Do you want to go to this release or next release? If this release, please retarget to release branch release-2022-10-12


# Version number of this module.
ModuleVersion = '1.4.0'
ModuleVersion = '1.5.0'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to update the version manually. Our tools will do it when build the release.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed manual version increment

* IsNullOrUndefined
* IsNotNull

## Version 1.50
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. No need to update the version manually. Our tools will do it when build the release.
  2. Just add changelog to section Upcoming Release

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed manual version increment and added changelog to the Upcoming Release section

@Brandon411
Copy link
Contributor Author

Brandon411 commented Oct 11, 2022

Do you want to go to this release or next release? If this release, please retarget to release branch release-2022-10-12

When is the next release? I don't think we will make the 10/12/2022 date.

@VeryEarly
Copy link
Collaborator

Do you want to go to this release or next release? If this release, please retarget to release branch release-2022-10-12

When is the next release? I don't think we will make the 10/12/2022 date.

it will be 2022-11-01

@VeryEarly VeryEarly self-assigned this Oct 17, 2022
@VeryEarly
Copy link
Collaborator

/azp run azure-powershell - security-tools

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@VeryEarly VeryEarly merged commit 4ab1da6 into Azure:main Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants