Skip to content

Conversation

@mwesigwaguma
Copy link
Contributor

@mwesigwaguma mwesigwaguma commented Mar 15, 2024

Description

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • For SDK-based development mode, update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • For autorest-based development mode, include the changelog in the PR description.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Mar 15, 2024

️✔️Az.Accounts
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.ServiceFabric
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Breaking Change Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Signature Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️File Change Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️UX Metadata Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️PowerShell Core - Linux
️✔️PowerShell Core - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows

@vidai-msft
Copy link
Contributor

@mwesigwaguma Please select the target release for this PR in the Mandatory Checklist section and update the ChangeLog.md.

@github-actions
Copy link

This PR was labeled "needs-revision" because it has unresolved review comments or CI failures.
Please resolve all open review comments and make sure all CI checks are green. Refer to our guide to troubleshoot common CI failures.

@mwesigwaguma mwesigwaguma requested a review from vidai-msft March 29, 2024 23:04
@vidai-msft
Copy link
Contributor

@mwesigwaguma Please select the target release for this PR in the Mandatory Checklist section and update the ChangeLog.md.

@mwesigwaguma Please take a look at the above action items.

@mwesigwaguma
Copy link
Contributor Author

mwesigwaguma commented Apr 1, 2024

@mwesigwaguma Please select the target release for this PR in the Mandatory Checklist section and update the ChangeLog.md.

@mwesigwaguma Please take a look at the above action items.

@vidai-msft updated

@vidai-msft
Copy link
Contributor

@mwesigwaguma You selected Public Preview as the target release. Can you please review this doc https://github.com/Azure/azure-powershell/blob/main/CONTRIBUTING.md#target-release-types and confirm if Public Preview is what you desired?

@mwesigwaguma
Copy link
Contributor Author

@mwesigwaguma You selected Public Preview as the target release. Can you please review this doc https://github.com/Azure/azure-powershell/blob/main/CONTRIBUTING.md#target-release-types and confirm if Public Preview is what you desired?

updated to general release

@YanaXu
Copy link
Contributor

YanaXu commented Apr 25, 2024

/azp run azure-powershell - security-tools

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@YanaXu YanaXu dismissed vidai-msft’s stale review April 25, 2024 07:00

It's updated.

@YanaXu YanaXu merged commit e1ca6c3 into Azure:main Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants