[PSCmdAssistant] Grant-AzDiskAccess new parameter SecureVMGuestStateSAS #24635
Conversation
️✔️Az.Accounts
️✔️Az.Compute
️✔️Az.KeyVault
️✔️Az.ManagedServiceIdentity
️✔️Az.Monitor
️✔️Az.Network
️✔️Az.OperationalInsights
️✔️Az.PrivateDns
|
| Type | Title | Current Coverage | Last Coverage | Description |
|---|---|---|---|---|
| Test Coverage Less Than 80% | 62.50 % | 66.67% | Test coverage cannot be lower than the number of the last release. |
⚠️ - MacOS
| Type | Title | Current Coverage | Last Coverage | Description |
|---|---|---|---|---|
| Test Coverage Less Than 80% | 62.50% | 66.67% | Test coverage cannot be lower than the number of the last release. |
⚠️ PowerShell Core - Windows
| Type | Title | Current Coverage | Last Coverage | Description |
|---|---|---|---|---|
| Test Coverage Less Than 80% | 62.50% | 66.67% | Test coverage cannot be lower than the number of the last release. |
⚠️ Windows PowerShell - Windows
| Type | Title | Current Coverage | Last Coverage | Description |
|---|---|---|---|---|
| Test Coverage Less Than 80% | 62.50% | 66.67% | Test coverage cannot be lower than the number of the last release. |
️✔️Az.Security
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️ - Linux
️✔️ - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Sql
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Ssh
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️ - Linux
️✔️ - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Storage
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
|
@Nickcandy , the test failure in ssh seems due to an error when trying to install from a repo PsGallery and failed to do so. I don't see how my changes would affect that. Might be due to the PsGallery not having a capital S. |
|
Hi @Sandido, is your pr ready for review? Cuz I saw it's draft. |
|
@Nickcandy , just reviewing it with my team first. |
|
Ready for merging |
|
Hi @Sandido , our code freeze time is PST 6PM Apr 22. If your code targets to this release, please finish resolving conflicts ASAP |
|
This PR was labeled "needs-revision" because it has unresolved review comments or CI failures. |
|
@Nickcandy , resolved. Looks like something tried to add back in the bug of ProgressAction paramter to the help doc. |
|
@Nickcandy the error in the 'azure-powershell security tools' check is no due to anything related to my edits. |
|
|
|
@Sandido, could you please resolve the conflicts? |
|
@YanaXu , resolved. Please merge when you can. This constant issue of conflicts with Changelog.md is quite annoying. |
Description
This one is a typical commit flow.
Feature implementation of: https://msazure.visualstudio.com/One/_workitems/edit/27063119
Design request: https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/1409
Added the new parameter SecureVmGuestStateSas to Grant-AzDiskAccess to return the securityDataAccessSAS value.
Mandatory Checklist
Please choose the target release of Azure PowerShell
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.