-
Notifications
You must be signed in to change notification settings - Fork 4.1k
Fix bug where parameters could not be toggled off #24705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
️✔️Az.Accounts
️✔️Az.Network
❌Az.Websites
|
|
To the author of the pull request, |
|
Hi @dannysongg, this PR introduce breaking changes which were not pre-announced in the former 2 releases. Please take the 2 PRs for example: Add upcoming Breaking Change message and the breaking change update. First, you have add the upcoming breaking change message in Az 12.1.0 (2024-07-02). |
|
|
|
@YanaXu this is a bug fix that fixes a CRI. Cx needs change released ASAP |
|
Hi @dannysongg, please confirm this: it's a bug fix, which means the cmdlet is not working before. Is this correct? |
|
/azp run |
Hi @dannysongg, please confirm this comment. FYI, the code freeze date is next Monday. |
|
@YanaXu yes this is a bug fix. This is fixing an unintended behavior reported by Cx. I will suppress the breaking change. |
…azure-powershell into ensure-params-toggle
Description
Some parameters for the Publish-AzWebApp cmdlet need to be able to be set to false. The current parameters are of type SwitchParameters so they can only be set to true. This change will change some parameters to the type nullable boolean. This is a bug fix.
Mandatory Checklist
Please choose the target release of Azure PowerShell
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.