Az.codesigning - fix regressions #26801
Conversation
By migrating to the rebranded Azure.Developer.TrustedSigning.CryptoProvider
️✔️Az.Accounts
|
| Type | Title | Current Coverage | Description |
|---|---|---|---|
| Test Coverage Less Than 50% | 0.00 % | Test coverage for the module cannot be lower than 50%. |
⚠️ - MacOS
| Type | Title | Current Coverage | Description |
|---|---|---|---|
| Test Coverage Less Than 50% | 0.00% | Test coverage for the module cannot be lower than 50%. |
⚠️ PowerShell Core - Windows
| Type | Title | Current Coverage | Description |
|---|---|---|---|
| Test Coverage Less Than 50% | 0.00% | Test coverage for the module cannot be lower than 50%. |
⚠️ Windows PowerShell - Windows
| Type | Title | Current Coverage | Description |
|---|---|---|---|
| Test Coverage Less Than 50% | 0.00% | Test coverage for the module cannot be lower than 50%. |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
Hi @Jaxelr , did you try to build the project in your local environment? dependencies don't look correct in pipeline build. |
|
@VeryEarly so I did, and didnt got this error, but Ill take a look, thanks for the callout. |
|
I added back the Polly dependency. That should resolve this issue. Looks like I cant build this pipeline unless I get your intervention? I'll try though. |
|
/azp run |
|
Commenter does not have sufficient privileges for PR 26801 in repo Azure/azure-powershell |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
please see new error message |
|
Silly me, thank you so much @VeryEarly I'll fix it right now. |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
* fix: regression failure using azure codesigning crypto provider By migrating to the rebranded Azure.Developer.TrustedSigning.CryptoProvider * docs: added changelog.md entries * fix: Polly dependency is still used on this version * fix: package of Polly should be on version 7.2.4
|
Thanks for your patience & guidance @VeryEarly |
2 participants
Description
This PR fixes #26764. The current Azure.CodeSigning.Client.CryptoProvider package has been deprecated and rebranded into Azure.Developer.TrustedSigning.CryptoProvider. The functionality is kept, with minor new class names. It also fixes a duplicate error on the Get Eku list.
Tagging @janielMartell for awareness.
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.