Skip to content

Conversation

@azure-powershell-bot
Copy link
Collaborator

Description

Migrate CostManagement from generation to main
The last commit of src/CostManagement in generation is:
commit 23e8b39 Author: Yabo Hu yabhu@microsoft.com Date: Tue Dec 3 18:44:25 2024 +0800 [CostManagement] Bugfix incorrect directive (#26805) * [CostManagement] Bugfix incorrect directive * Update README.md

Checklist

  • SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
  • SHOULD make the title of PR clear and informative, and in the present imperative tense.
  • SHOULD update ChangeLog.md file(s) appropriately
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
    • Create new module from scratch
    • Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
    • Create new resource type which name doesn't use module name as prefix
    • Have design question before implementation
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT introduce breaking changes in Az minor release except preview version.
  • SHOULD NOT adjust version of module manually in pull request

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Dec 3, 2024

️✔️Az.Accounts
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️Az.CostManagement
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Breaking Change Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️Signature Check
⚠️PowerShell Core - Windows
Type Cmdlet Description Remediation
⚠️ Get-AzCostManagementExport Get-AzCostManagementExport Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzCostManagementExport Get-AzCostManagementExport changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzCostManagementExportExecutionHistory Get-AzCostManagementExportExecutionHistory Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzCostManagementExportExecutionHistory Get-AzCostManagementExportExecutionHistory changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ New-AzCostManagementQueryComparisonExpressionObject New-AzCostManagementQueryComparisonExpressionObject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ New-AzCostManagementQueryFilterObject New-AzCostManagementQueryFilterObject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️Windows PowerShell - Windows
Type Cmdlet Description Remediation
⚠️ Get-AzCostManagementExport Get-AzCostManagementExport Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzCostManagementExport Get-AzCostManagementExport changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzCostManagementExportExecutionHistory Get-AzCostManagementExportExecutionHistory Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzCostManagementExportExecutionHistory Get-AzCostManagementExportExecutionHistory changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ New-AzCostManagementQueryComparisonExpressionObject New-AzCostManagementQueryComparisonExpressionObject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ New-AzCostManagementQueryFilterObject New-AzCostManagementQueryFilterObject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️Help Example Check
⚠️PowerShell Core - Windows
Type Cmdlet Example Line RuleName Description Extent Remediation
⚠️ Get-AzCostManagementExportExecutionHistory 2 2 Mismatched_Parameter_Value_Type Get-AzCostManagementExportExecutionHistory -InputObject $getExport is not an expected parameter value type. -InputObject Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.CostManagement.Models.ICostManagementIdentity. Now the type is Microsoft.Azure.PowerShell.Cmdlets.CostManagement.Models.Api20211001.IExport.(Command).
⚠️ Invoke-AzCostManagementExecuteExport 2 2 Mismatched_Parameter_Value_Type Invoke-AzCostManagementExecuteExport -InputObject $getExport is not an expected parameter value type. -InputObject Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.CostManagement.Models.ICostManagementIdentity. Now the type is Microsoft.Azure.PowerShell.Cmdlets.CostManagement.Models.Api20211001.IExport.(Command).
⚠️ Remove-AzCostManagementExport 2 2 Mismatched_Parameter_Value_Type Remove-AzCostManagementExport -InputObject $getExport is not an expected parameter value type. -InputObject Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.CostManagement.Models.ICostManagementIdentity. Now the type is Microsoft.Azure.PowerShell.Cmdlets.CostManagement.Models.Api20211001.IExport.(Command).
⚠️ Update-AzCostManagementExport 2 2 Mismatched_Parameter_Value_Type Update-AzCostManagementExport -InputObject $oldExport is not an expected parameter value type. -InputObject Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.CostManagement.Models.ICostManagementIdentity. Now the type is Microsoft.Azure.PowerShell.Cmdlets.CostManagement.Models.Api20211001.IExport.(Command).
⚠️Windows PowerShell - Windows
Type Cmdlet Example Line RuleName Description Extent Remediation
⚠️ Get-AzCostManagementExportExecutionHistory 2 2 Mismatched_Parameter_Value_Type Get-AzCostManagementExportExecutionHistory -InputObject $getExport is not an expected parameter value type. -InputObject Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.CostManagement.Models.ICostManagementIdentity. Now the type is Microsoft.Azure.PowerShell.Cmdlets.CostManagement.Models.Api20211001.IExport.(Command).
⚠️ Invoke-AzCostManagementExecuteExport 2 2 Mismatched_Parameter_Value_Type Invoke-AzCostManagementExecuteExport -InputObject $getExport is not an expected parameter value type. -InputObject Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.CostManagement.Models.ICostManagementIdentity. Now the type is Microsoft.Azure.PowerShell.Cmdlets.CostManagement.Models.Api20211001.IExport.(Command).
⚠️ Remove-AzCostManagementExport 2 2 Mismatched_Parameter_Value_Type Remove-AzCostManagementExport -InputObject $getExport is not an expected parameter value type. -InputObject Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.CostManagement.Models.ICostManagementIdentity. Now the type is Microsoft.Azure.PowerShell.Cmdlets.CostManagement.Models.Api20211001.IExport.(Command).
⚠️ Update-AzCostManagementExport 2 2 Mismatched_Parameter_Value_Type Update-AzCostManagementExport -InputObject $oldExport is not an expected parameter value type. -InputObject Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.CostManagement.Models.ICostManagementIdentity. Now the type is Microsoft.Azure.PowerShell.Cmdlets.CostManagement.Models.Api20211001.IExport.(Command).
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️File Change Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️UX Metadata Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️PowerShell Core - Linux
️✔️PowerShell Core - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows

@VeryEarly VeryEarly self-assigned this Dec 4, 2024
@VeryEarly VeryEarly merged commit 433046f into main Dec 4, 2024
12 checks passed
@VeryEarly VeryEarly deleted the codegen/CostManagement branch December 4, 2024 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants