Skip to content

Conversation

@riyanshpal
Copy link
Contributor

@riyanshpal riyanshpal commented Mar 3, 2025

Description

Added the support for PremiumV2_LRS and UltraSSD_LRS target disks for ASR.

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • For SDK-based development mode, update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • For autorest-based development mode, include the changelog in the PR description.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

@azure-client-tools-bot-prd
Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

Copy link
Member

@vidyadharijami vidyadharijami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the scenario test and recording.

Also update ChangeLog.md describing the feature.

Constants.Standard_LRS,
Constants.Standard_SSD,
Constants.StandardSSD_LRS,
Constants.StandardSSD_ZRS)]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change not needed for Update cmdlet ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, We only support PremiumV2_LRS and UltraSSD_LRS Target disk type only when source is PremiumV2_LRS and UltraSSD_LRS respectively. So did not need change for Update cmdlet.

@riyanshpal
Copy link
Contributor Author

Please add the scenario test and recording.

Also update ChangeLog.md describing the feature.

Added in latest revision.

@riyanshpal riyanshpal closed this Mar 5, 2025
@riyanshpal riyanshpal reopened this Mar 5, 2025
@riyanshpal
Copy link
Contributor Author

Please add the scenario test and recording.

Also update ChangeLog.md describing the feature.

Updated in latest revision.

Copy link
Member

@vidyadharijami vidyadharijami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@notyashhh
Copy link
Member

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@notyashhh
Copy link
Member

@riyanshpal, please accept the contributor agreement, follow the #27257 (comment) bot instructions.

@notyashhh notyashhh self-assigned this Mar 11, 2025
@riyanshpal
Copy link
Contributor Author

@riyanshpal please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree company="Microsoft"

@notyashhh
Copy link
Member

@riyanshpal Please, resolve merge conflicts

@riyanshpal riyanshpal force-pushed the dev/riyanshpal/pv2AndUltraDiskSupport branch from df5180d to ec1e75b Compare March 15, 2025 10:15
@riyanshpal
Copy link
Contributor Author

@riyanshpal Please, resolve merge conflicts

Resolved.

@notyashhh
Copy link
Member

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@riyanshpal riyanshpal requested a review from notyashhh March 17, 2025 06:38
@notyashhh
Copy link
Member

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

Copy link
Member

@notyashhh notyashhh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good!

@notyashhh notyashhh merged commit 7b1f978 into Azure:main Mar 18, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants