-
Notifications
You must be signed in to change notification settings - Fork 4.1k
Add support for PremiumV2_LRS and UltraSSD_LRS target disks #27257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for PremiumV2_LRS and UltraSSD_LRS target disks #27257
Conversation
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
vidyadharijami
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add the scenario test and recording.
Also update ChangeLog.md describing the feature.
| Constants.Standard_LRS, | ||
| Constants.Standard_SSD, | ||
| Constants.StandardSSD_LRS, | ||
| Constants.StandardSSD_ZRS)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this change not needed for Update cmdlet ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, We only support PremiumV2_LRS and UltraSSD_LRS Target disk type only when source is PremiumV2_LRS and UltraSSD_LRS respectively. So did not need change for Update cmdlet.
Added in latest revision. |
Updated in latest revision. |
vidyadharijami
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
@riyanshpal, please accept the contributor agreement, follow the #27257 (comment) bot instructions. |
@microsoft-github-policy-service agree company="Microsoft" |
|
@riyanshpal Please, resolve merge conflicts |
df5180d to
ec1e75b
Compare
Resolved. |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
notyashhh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Good!
Description
Added the support for PremiumV2_LRS and UltraSSD_LRS target disks for ASR.
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.