Skip to content

Conversation

@Pan-Qi
Copy link
Contributor

@Pan-Qi Pan-Qi commented Mar 6, 2025

Description

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • For SDK-based development mode, update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • For autorest-based development mode, include the changelog in the PR description.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

@azure-client-tools-bot-prd
Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

@Pan-Qi Pan-Qi force-pushed the bernard-upgrade-portal-module-to-autorest-v4 branch from 5ce5b68 to c170ff8 Compare March 25, 2025 11:58
@Pan-Qi Pan-Qi force-pushed the bernard-upgrade-portal-module-to-autorest-v4 branch from c170ff8 to aeefef4 Compare March 25, 2025 12:13
@Pan-Qi Pan-Qi marked this pull request as ready for review March 26, 2025 04:14
@dolauli dolauli self-assigned this Mar 27, 2025
dolauli
dolauli previously approved these changes Apr 3, 2025

directive:
- where:
verb: Set
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow the guide to migrate directives below.

  - where:
      verb: New
      subject: Dashboard
      variant: CreateViaIdentity|CreateViaIdentityExpanded
    remove: true
  - where:
      verb: Update
      subject: Dashboard
      variant: ^Update$|^UpdateViaIdentity$
    remove: true

@dolauli dolauli self-requested a review April 3, 2025 07:58
@dolauli dolauli dismissed their stale review April 3, 2025 07:58

Click approval by mistake

@github-actions
Copy link

github-actions bot commented Apr 8, 2025

This PR was labeled "needs-revision" because it has unresolved review comments or CI failures.
Please resolve all open review comments and make sure all CI checks are green. Refer to our guide to troubleshoot common CI failures.

@dolauli dolauli merged commit c926eab into main Apr 15, 2025
12 checks passed
@dolauli dolauli deleted the bernard-upgrade-portal-module-to-autorest-v4 branch April 15, 2025 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants