Skip to content

Conversation

@VeryEarly
Copy link
Collaborator

@VeryEarly VeryEarly commented Mar 19, 2025

Description

for autorest based modules, custom/*.psm1 is needed to properly import custom cmdlets. Remove them from .gitignore

ls .\src\*/*.Autorest | 
    where-object {
        $name=($_.Name -split ".Autorest")[0]; 
        -not (Test-Path (Join-Path $_.FullName "custom" "Az.$name.custom.psm1"))
    }

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • For SDK-based development mode, update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • For autorest-based development mode, include the changelog in the PR description.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

@azure-client-tools-bot-prd
Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

@VeryEarly VeryEarly marked this pull request as draft March 19, 2025 05:57
@VeryEarly VeryEarly changed the title [Eng] Remove custom/*.psm1 from .gitignore Remove custom/*.psm1 from .gitignore Mar 19, 2025
@VeryEarly VeryEarly marked this pull request as ready for review March 19, 2025 06:24
notyashhh
notyashhh previously approved these changes Mar 19, 2025
Copy link
Member

@notyashhh notyashhh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@VeryEarly VeryEarly merged commit 9926357 into main Mar 19, 2025
12 checks passed
@VeryEarly VeryEarly deleted the yabo/fix-missed-psm1 branch March 19, 2025 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants