Skip to content

Conversation

@EmmaZhu
Copy link
Member

@EmmaZhu EmmaZhu commented Mar 21, 2025

Description

The warning message will be shown like:
image

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • For SDK-based development mode, update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • For autorest-based development mode, include the changelog in the PR description.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

@azure-client-tools-bot-prd
Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

@EmmaZhu EmmaZhu force-pushed the storage/migration_break_warning branch from fcd9561 to 25f2acf Compare March 21, 2025 03:45
@notyashhh
Copy link
Member

/azp run

@notyashhh notyashhh self-assigned this Mar 21, 2025
@notyashhh notyashhh added this to the Az 13.4.0 (04/01/2025) milestone Mar 21, 2025
@notyashhh notyashhh added the Breaking Change Preannounce This PR adds preannouncement about upcoming breaking change label Mar 21, 2025
@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@VeryEarly
Copy link
Collaborator

  • please add changelog

  • meanwhile, giving that storage has too many changes in help markdown which makes PR difficult to review, can you please sync latest main branch and run build-module.ps1 again? I made some changes in script to get rid of irrelevant help markdowns

internal
exports
tools
custom/*.psm1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • please run autorest --reset to get latest autorest
  • re-run autorest to regenerate
  • make sure update in this file was checked in

@EmmaZhu EmmaZhu force-pushed the storage/migration_break_warning branch 2 times, most recently from 016c37b to 69940b6 Compare March 24, 2025 02:22
Set-AzStorageAccountManagementPolicy [-ResourceGroupName] <String> [-StorageAccountName] <String>
-Rule <PSManagementPolicyRule[]> [-DefaultProfile <IAzureContextContainer>] [-WhatIf] [-Confirm]
[<CommonParameters>]
-Rule <PSManagementPolicyRule[]> [-DefaultProfile <IAzureContextContainer>]
Copy link
Member

@blueww blueww Mar 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert change of this file. the file don't need change.
@VeryEarly It looks the file will have several repeated parameters when run build-module again. It would be great if you could help to resolve it!

@VeryEarly
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@EmmaZhu EmmaZhu force-pushed the storage/migration_break_warning branch from 69940b6 to ac0148b Compare March 24, 2025 03:01
@VeryEarly
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@VeryEarly VeryEarly merged commit 54018a5 into Azure:main Mar 24, 2025
12 checks passed
@EmmaZhu EmmaZhu deleted the storage/migration_break_warning branch March 24, 2025 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Breaking Change Preannounce This PR adds preannouncement about upcoming breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants