Skip to content

Conversation

@GovardhanaDK
Copy link
Contributor

Description

Moving to the latest stable version. This supports -SkuModel which is a necessary property for working with V2 SKUs

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • For SDK-based development mode, update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • For autorest-based development mode, include the changelog in the PR description.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

@azure-client-tools-bot-prd
Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 42 out of 53 changed files in this pull request and generated no comments.

Files not reviewed (11)
  • src/DataBox/DataBox.Autorest/UX/Microsoft.DataBox/jobs.json: Language not supported
  • src/DataBox/DataBox.Autorest/custom/AzDataBoxCustomerDiskJobDetailsObject.ps1: Language not supported
  • src/DataBox/DataBox.Autorest/custom/autogen-model-cmdlets/New-AzDataBoxContactDetailsObject.ps1: Language not supported
  • src/DataBox/DataBox.Autorest/custom/autogen-model-cmdlets/New-AzDataBoxDiskJobDetailsObject.ps1: Language not supported
  • src/DataBox/DataBox.Autorest/custom/autogen-model-cmdlets/New-AzDataBoxHeavyJobDetailsObject.ps1: Language not supported
  • src/DataBox/DataBox.Autorest/custom/autogen-model-cmdlets/New-AzDataBoxJobDetailsObject.ps1: Language not supported
  • src/DataBox/DataBox.Autorest/custom/autogen-model-cmdlets/New-AzDataBoxKeyEncryptionKeyObject.ps1: Language not supported
  • src/DataBox/DataBox.Autorest/custom/autogen-model-cmdlets/New-AzDataBoxManagedDiskDetailsObject.ps1: Language not supported
  • src/DataBox/DataBox.Autorest/custom/autogen-model-cmdlets/New-AzDataBoxShippingAddressObject.ps1: Language not supported
  • src/DataBox/DataBox.Autorest/custom/autogen-model-cmdlets/New-AzDataBoxStorageAccountDetailsObject.ps1: Language not supported
  • src/DataBox/DataBox.Autorest/custom/autogen-model-cmdlets/New-AzDataBoxTransferConfigurationObject.ps1: Language not supported

@dolauli dolauli self-assigned this Apr 16, 2025
@dolauli
Copy link
Contributor

dolauli commented Apr 16, 2025

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@GovardhanaDK
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link
Contributor

Commenter does not have sufficient privileges for PR 27577 in repo Azure/azure-powershell

@GovardhanaDK
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link
Contributor

Commenter does not have sufficient privileges for PR 27577 in repo Azure/azure-powershell

@GovardhanaDK
Copy link
Contributor Author

@dolauli I have made changes to the test case. Please do trigger the test pipelines now

@dolauli
Copy link
Contributor

dolauli commented Apr 18, 2025

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@dolauli
Copy link
Contributor

dolauli commented Apr 18, 2025

Please update the https://github.com/GovardhanaDK/azure-powershell/blob/main/src/DataBox/DataBox/ChangeLog.md accordingly otherwise your change will not be included in our next release.

@GovardhanaDK
Copy link
Contributor Author

@dolauli I have updated the version and ChangeLog.md file

The cred scan failure is because of
image
This is a random password we are using for our tests to test the flow where the customer enters their own device password.

@dolauli
Copy link
Contributor

dolauli commented Apr 18, 2025

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@dolauli
Copy link
Contributor

dolauli commented Apr 18, 2025

@dolauli I have updated the version and ChangeLog.md file

The cred scan failure is because of image This is a random password we are using for our tests to test the flow where the customer enters their own device password.

Change it to something like "******" when you create the PR

@GovardhanaDK
Copy link
Contributor Author

@dolauli I have updated the version and ChangeLog.md file
The cred scan failure is because of image This is a random password we are using for our tests to test the flow where the customer enters their own device password.

Change it to something like "******" when you create the PR

Changing it ****** will cause the test case to fail. I have added the two files under CredScanSupression as they are just test related file and the passwored is not an actual password.
The password is used to lock files on a device. Since there is no device involved here, the password is never actuallly used

@dolauli
Copy link
Contributor

dolauli commented Apr 18, 2025

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@dolauli dolauli merged commit fc01efa into Azure:main Apr 18, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants