-
Couldn't load subscription status.
- Fork 4.1k
skip failed RecoveryServices tests #28194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR skips failing RecoveryServices tests by adding Skip attributes to test methods that are currently broken and awaiting fixes. The changes disable 4 specific test methods across the Site Recovery and Backup test suites to prevent test failures while fixes are being developed.
- Adds Skip attributes to broken A2A managed disk replication configuration tests
- Skips failing A2A container test
- Disables broken SQL container registration error test
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| AsrA2ATests.cs | Skips 3 A2A test methods related to managed disk replication configuration and container operations |
| ContainerTests.cs | Skips 1 SQL container registration error test method |
Comments suppressed due to low confidence (4)
src/RecoveryServices/RecoveryServices.SiteRecovery.Test/ScenarioTests/A2A/AsrA2ATests.cs:53
- The skip message is generic and unhelpful for debugging. Consider providing more specific information about what is broken or a reference to a tracking issue (e.g., 'Skip = "Failing due to authentication issues - tracked in issue #1234"').
[Fact(Skip = "The test is broken and waiting for a fix.")]
src/RecoveryServices/RecoveryServices.SiteRecovery.Test/ScenarioTests/A2A/AsrA2ATests.cs:63
- The skip message is generic and unhelpful for debugging. Consider providing more specific information about what is broken or a reference to a tracking issue (e.g., 'Skip = "Failing due to authentication issues - tracked in issue #1234"').
[Fact(Skip = "The test is broken and waiting for a fix.")]
src/RecoveryServices/RecoveryServices.SiteRecovery.Test/ScenarioTests/A2A/AsrA2ATests.cs:101
- The skip message is generic and unhelpful for debugging. Consider providing more specific information about what is broken or a reference to a tracking issue (e.g., 'Skip = "Failing due to authentication issues - tracked in issue #1234"').
[Fact(Skip = "The test is broken and waiting for a fix.")]
src/RecoveryServices/RecoveryServices.Backup.Test/ScenarioTests/AzureWorkload/ContainerTests.cs:63
- The skip message is generic and unhelpful for debugging. Consider providing more specific information about what is broken or a reference to a tracking issue (e.g., 'Skip = "Failing due to authentication issues - tracked in issue #1234"').
[Fact(Skip = "The test is broken and waiting for a fix.")]
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
Hi @riyanshpal, please fix them later and remove the skip line. Thanks. |
Description
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.