migrate workloads sapVirtualInstance to autorest v4

src/Workloads/SapVirtualInstance.Autorest/Properties/AssemblyInfo.cs

@@ -20,7 +20,7 @@
 [assembly: System.Reflection.AssemblyCopyrightAttribute("Copyright © Microsoft")]
 [assembly: System.Reflection.AssemblyProductAttribute("Microsoft Azure PowerShell")]
 [assembly: System.Reflection.AssemblyTitleAttribute("Microsoft Azure PowerShell - SapVirtualInstance")]
-[assembly: System.Reflection.AssemblyFileVersionAttribute("1.0.0")]
-[assembly: System.Reflection.AssemblyVersionAttribute("1.0.0")]
+[assembly: System.Reflection.AssemblyFileVersionAttribute("1.0.1")]
+[assembly: System.Reflection.AssemblyVersionAttribute("1.0.1")]
 [assembly: System.Runtime.InteropServices.ComVisibleAttribute(false)]
 [assembly: System.CLSCompliantAttribute(false)]

src/Workloads/SapVirtualInstance.Autorest/README.md

@@ -44,39 +44,22 @@ root-module-name: $(prefix).Workloads
 title: SapVirtualInstance
 subject-prefix: Workloads
 namespace: Microsoft.Azure.PowerShell.Cmdlets.Workloads.SapVirtualInstance
-resourcegroup-append: true
-identity-correction-for-post: true
-nested-object-to-string: true
-#add-api-version-in-model-namespace: true
 inlining-threshold: 100
 
-# For new modules, please avoid setting 3.x using the use-extension method and instead, use 4.x as the default option
-use-extension:
- "@autorest/powershell": "3.x"
+flatten-userassignedidentity: false
+disable-transform-identity-type: true
 
 directive:
 - where:
-    verb: New
-    subject: ^SapApplicationServerInstance$
-  remove: true
-
-- where:
-    verb: Stop
-    subject: ^SapApplicationServerInstance$
-    variant: ^Stop$|^StopViaIdentity$
+    variant: ^(Stop|Update)(?!.*?(Expanded|JsonFilePath|JsonString))
   remove: true
 
 - where:
-    verb: Update
-    subject: ^SapApplicationServerInstance$
-    variant: ^Update$|^UpdateViaIdentity$
-  remove: true
-
-- where:
-    verb: Remove
-    subject: ^SapApplicationServerInstance$
+    verb: New|Remove
+    subject: ^SapApplicationServerInstance$|^SapCentralServerInstance$|^SapDatabaseInstance$
   remove: true
 
+#SapApplicationInstance
 - where:
     subject: SapApplicationServerInstance
   set:
@@ -89,28 +72,6 @@ directive:
     parameter-name: Name
 
 # SapCentralInstance
-- where:
-    verb: New
-    subject: ^SapCentralServerInstance$
-  remove: true
-
-- where:
-    verb: Stop
-    subject: ^SapCentralServerInstance$
-    variant: ^Stop$|^StopViaIdentity$
-  remove: true
-
-- where:
-    verb: Update
-    subject: ^SapCentralServerInstance$
-    variant: ^Update$|^UpdateViaIdentity$
-  remove: true
-
-- where:
-    verb: Remove
-    subject: ^SapCentralServerInstance$
-  remove: true
-
 - where:
     subject: SapCentralServerInstance
     parameter-name: CentralInstanceName
@@ -124,28 +85,6 @@ directive:
     subject: SapCentralInstance
 
 # SapDatabaseInstance
-- where:
-    verb: New
-    subject: ^SapDatabaseInstance$
-  remove: true
-
-- where:
-    verb: Stop
-    subject: ^SapDatabaseInstance$
-    variant: ^Stop$|^StopViaIdentity$
-  remove: true
-
-- where:
-    verb: Update
-    subject: ^SapDatabaseInstance$
-    variant: ^Update$|^UpdateViaIdentity$
-  remove: true
-
-- where:
-    verb: Remove
-    subject: ^SapDatabaseInstance$
-  remove: true
-
 - where:
     subject: SapDatabaseInstance
     parameter-name: DatabaseInstanceName
@@ -156,7 +95,7 @@ directive:
 - where:
     verb: New
     subject: ^SapVirtualInstance$
-    variant: ^Create$|^CreateViaIdentity$|^CreateViaIdentityExpanded$
+    variant: ^(Create)(?!.*?(Expanded|JsonFilePath|JsonString))|^CreateViaIdentityExpanded$
   remove: true
 
 - where:
@@ -166,28 +105,15 @@ directive:
   hide: true
 
 - where:
-    verb: Stop
     subject: ^SapVirtualInstance$
-    variant: ^Stop$|^StopViaIdentity$
-  remove: true
-
-- where:
-    verb: Update
-    subject: ^SapVirtualInstance$
-    variant: ^Update$|^UpdateViaIdentity$
-  remove: true
-
-- where:
-    subject: ^SapVirtualInstance$
-    parameter-name: IdentityUserAssignedIdentity
+    parameter-name: ManagedResourceGroupConfigurationName
   set:
-    parameter-name: UserAssignedIdentity
+    parameter-name: ManagedResourceGroupName
 
 - where:
+    verb: Update
     subject: ^SapVirtualInstance$
-    parameter-name: ManagedResourceGroupConfigurationName
-  set:
-    parameter-name: ManagedResourceGroupName
+  hide: true
 
 # SapAvailabilityZoneDetail
 - where:
@@ -430,43 +356,22 @@ directive:
 # Result shoule be in SingleServerRecommendationResult and ThreeTierRecommendationResult
 - from: source-file-csharp
   where: $
-  transform: $ = $.replace('internal Microsoft.Azure.PowerShell.Cmdlets.Workloads.Models.Api20231001Preview.ISapSizingRecommendationResult Property', 'public Microsoft.Azure.PowerShell.Cmdlets.Workloads.Models.Api20240901.ISapSizingRecommendationResult Property');
+  transform: $ = $.replace('internal Microsoft.Azure.PowerShell.Cmdlets.Workloads.Models.ISapSizingRecommendationResult Property', 'public Microsoft.Azure.PowerShell.Cmdlets.Workloads.Models.ISapSizingRecommendationResult Property');
 
 # remove System Data in module Monitor, ProviderInstance, SapApplicationServerInstance, SapCentralServerInstance, SapDatabaseInstance, SapLandscapeMonitor, SapVirtualInstance
 - from: SapApplicationServerInstance.cs
   where: $
-  transform: $ = $.replace('public Microsoft.Azure.PowerShell.Cmdlets.Workloads.Models.Api30.ISystemData SystemData', 'internal Microsoft.Azure.PowerShell.Cmdlets.Workloads.Models.Api50.ISystemData SystemData');
+  transform: $ = $.replace('public Microsoft.Azure.PowerShell.Cmdlets.Workloads.Models.ISystemData SystemData', 'internal Microsoft.Azure.PowerShell.Cmdlets.Workloads.Models.ISystemData SystemData');
 - from: SapCentralServerInstance.cs
   where: $
-  transform: $ = $.replace('public Microsoft.Azure.PowerShell.Cmdlets.Workloads.Models.Api30.ISystemData SystemData', 'internal Microsoft.Azure.PowerShell.Cmdlets.Workloads.Models.Api50.ISystemData SystemData');
+  transform: $ = $.replace('public Microsoft.Azure.PowerShell.Cmdlets.Workloads.Models.ISystemData SystemData', 'internal Microsoft.Azure.PowerShell.Cmdlets.Workloads.Models.ISystemData SystemData');
 - from: SapDatabaseInstance.cs
   where: $
-  transform: $ = $.replace('public Microsoft.Azure.PowerShell.Cmdlets.Workloads.Models.Api30.ISystemData SystemData', 'internal Microsoft.Azure.PowerShell.Cmdlets.Workloads.Models.Api50.ISystemData SystemData');
+  transform: $ = $.replace('public Microsoft.Azure.PowerShell.Cmdlets.Workloads.Models.ISystemData SystemData', 'internal Microsoft.Azure.PowerShell.Cmdlets.Workloads.Models.ISystemData SystemData');
 - from: SapLandscapeMonitor.cs
   where: $
-  transform: $ = $.replace('public Microsoft.Azure.PowerShell.Cmdlets.Workloads.Models.Api30.ISystemData SystemData', 'internal Microsoft.Azure.PowerShell.Cmdlets.Workloads.Models.Api50.ISystemData SystemData');
+  transform: $ = $.replace('public Microsoft.Azure.PowerShell.Cmdlets.Workloads.Models.ISystemData SystemData', 'internal Microsoft.Azure.PowerShell.Cmdlets.Workloads.Models.ISystemData SystemData');
 - from: SapVirtualInstance.cs
   where: $
-  transform: $ = $.replace('public Microsoft.Azure.PowerShell.Cmdlets.Workloads.Models.Api30.ISystemData SystemData', 'internal Microsoft.Azure.PowerShell.Cmdlets.Workloads.Models.Api50.ISystemData SystemData');
-
-- where:
-    verb: Get|Start|Stop|Update
-    subject: SapApplicationInstance|SapCentralInstance|SapDatabaseInstance|SapVirtualInstance
-  set:
-    preview-announcement:
-      preview-message: "*****************************************************************************************\\r\\n* This cmdlet will undergo a breaking change in Az v15.0.0, to be released on November 19th 2025. *\\r\\n* At least one change applies to this cmdlet.                                                     *\\r\\n* See all possible breaking changes at https://go.microsoft.com/fwlink/?linkid=2333486            *\\r\\n**************************************************************************************************"
-
-- where:
-    verb: Invoke
-    subject: SapDiskConfiguration|SapSizingRecommendation|SapSupportedSku
-  set:
-    preview-announcement:
-      preview-message: "*****************************************************************************************\\r\\n* This cmdlet will undergo a breaking change in Az v15.0.0, to be released on November 19th 2025. *\\r\\n* At least one change applies to this cmdlet.                                                     *\\r\\n* See all possible breaking changes at https://go.microsoft.com/fwlink/?linkid=2333486            *\\r\\n**************************************************************************************************"
-
-- where:
-    verb: New
-    subject: SapVirtualInstance
-  set:
-    preview-announcement:
-      preview-message: "*****************************************************************************************\\r\\n* This cmdlet will undergo a breaking change in Az v15.0.0, to be released on November 19th 2025. *\\r\\n* At least one change applies to this cmdlet.                                                     *\\r\\n* See all possible breaking changes at https://go.microsoft.com/fwlink/?linkid=2333486            *\\r\\n**************************************************************************************************"
+  transform: $ = $.replace('public Microsoft.Azure.PowerShell.Cmdlets.Workloads.Models.ISystemData SystemData', 'internal Microsoft.Azure.PowerShell.Cmdlets.Workloads.Models.ISystemData SystemData');
 ```

src/Workloads/SapVirtualInstance.Autorest/UX/Microsoft.Workloads/sapVirtualInstances-applicationInstances.json

@@ -47,49 +47,6 @@
           ]
         }
       ]
-    },
-    {
-      "name": "Start-AzWorkloadsSapApplicationInstance",
-      "description": "Starts the SAP Application Server Instance.",
-      "path": "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Workloads/sapVirtualInstances/{sapVirtualInstanceName}/applicationInstances/{applicationInstanceName}/start",
-      "help": {
-        "learnMore": {
-          "url": "https://learn.microsoft.com/powershell/module/az.workloads/start-azworkloadssapapplicationinstance"
-        },
-        "parameterSets": [
-          {
-            "parameters": [
-              "-Name <String>",
-              "-ResourceGroupName <String>",
-              "-SapVirtualInstanceName <String>",
-              "[-SubscriptionId <String>]"
-            ]
-          }
-        ]
-      },
-      "examples": [
-        {
-          "description": "Starts the SAP Application Server Instance.",
-          "parameters": [
-            {
-              "name": "-Name",
-              "value": "[Path.applicationInstanceName]"
-            },
-            {
-              "name": "-ResourceGroupName",
-              "value": "[Path.resourceGroupName]"
-            },
-            {
-              "name": "-SapVirtualInstanceName",
-              "value": "[Path.sapVirtualInstanceName]"
-            },
-            {
-              "name": "-SubscriptionId",
-              "value": "[Path.subscriptionId]"
-            }
-          ]
-        }
-      ]
     }
   ]
 }