-
Notifications
You must be signed in to change notification settings - Fork 4.1k
Az.Compute - MSP AddProxyAgentExtension parameter #28634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Commenter does not have sufficient privileges for PR 28634 in repo Azure/azure-powershell |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
f311d48 to
a2d6b22
Compare
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
25d8194 to
39e97a3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds the AddProxyAgentExtension parameter to Azure PowerShell compute cmdlets as requested in the linked issue. The parameter enables implicit installation of the ProxyAgent Extension, which is currently applicable only for Linux OS.
Key changes include:
- Added
AddProxyAgentExtensionparameter toNew-AzVMandNew-AzVmssas a switch parameter - Added
AddProxyAgentExtensionparameter toSet-AzVMProxyAgentSettingandSet-AzVmssProxyAgentSettingas a boolean parameter - Updated underlying strategy and model classes to support the new parameter
Reviewed Changes
Copilot reviewed 18 out of 92 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| help/*.md files | Updated documentation to include the new AddProxyAgentExtension parameter |
| NewAzureVMCommand.cs | Added AddProxyAgentExtension switch parameter to New-AzVM cmdlet |
| SetAzVMProxyAgentSetting.cs | Added AddProxyAgentExtension boolean parameter to Set-AzVMProxyAgentSetting cmdlet |
| VirtualMachineStrategy.cs | Updated strategy to handle the new parameter in VM creation |
| VirtualMachineScaleSetStrategy.cs | Updated strategy to handle the new parameter in VMSS creation |
| VirtualMachineScaleSetCreateOrUpdateMethod.cs | Added AddProxyAgentExtension switch parameter to New-AzVmss cmdlet |
| Model classes | Added AddProxyAgentExtension property to PowerShell model objects |
| Test files | Added test scenarios for the new functionality |
| ChangeLog.md | Documented the new parameter additions |
| ComputeRP.json | Updated to API version 2025-04-01 with various enhancements |
src/Compute/Compute/VirtualMachine/Config/SetAzVMProxyAgentSetting.cs
Outdated
Show resolved
Hide resolved
src/Compute/Compute/VirtualMachine/Config/SetAzVMProxyAgentSetting.cs
Outdated
Show resolved
Hide resolved
src/Compute/Compute/Strategies/ComputeRp/VirtualMachineScaleSetStrategy.cs
Outdated
Show resolved
Hide resolved
src/Compute/Compute/Strategies/ComputeRp/VirtualMachineScaleSetStrategy.cs
Outdated
Show resolved
Hide resolved
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
e0681a7 to
7b3b084
Compare
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
@isra-fel @wyunchi-ms @dolauli @VeryEarly Can I please get eyes on this PR? Feature is for Ignite and passing all CI checks, thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see comments
src/Compute/Compute/Generated/VirtualMachineScaleSet/Config/SetAzVmssProxyAgentSetting.cs
Outdated
Show resolved
Hide resolved
src/Compute/Compute/Manual/VirtualMachineScaleSetCreateOrUpdateMethod.cs
Outdated
Show resolved
Hide resolved
src/Compute/Compute/Strategies/ComputeRp/VirtualMachineStrategy.cs
Outdated
Show resolved
Hide resolved
src/Compute/Compute/Strategies/ComputeRp/VirtualMachineScaleSetStrategy.cs
Outdated
Show resolved
Hide resolved
src/Compute/Compute/Strategies/ComputeRp/VirtualMachineScaleSetStrategy.cs
Outdated
Show resolved
Hide resolved
src/Compute/Compute/VirtualMachine/Config/SetAzVMProxyAgentSetting.cs
Outdated
Show resolved
Hide resolved
src/Compute/Compute/VirtualMachine/Operation/NewAzureVMCommand.cs
Outdated
Show resolved
Hide resolved
src/Compute/Compute.Test/ScenarioTests/VirtualMachineScaleSetTests.ps1
Outdated
Show resolved
Hide resolved
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@ookoka please try this and see if we can get a green on the last check |
@microsoft-github-policy-service agree company="Microsoft" |
|
@microsoft-github-policy-service agree company="Microsoft" |
@isra-fel Do we need to rerun the check? I have replied to the comment but I'm not sure if it is supposed to automatically trigger the pipeline stage. Seems as though it shows status of being ongoing for hours |
|
@microsoft-github-policy-service rerun |
|
@ookoka please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
|
Let me try closing and reopening |
|
@ookoka please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
@microsoft-github-policy-service agree company="Microsoft" |
Description
Adding MSP AddProxyAgentExtension parameter to New-AzVM, New-AzVMss, Set-AzVMProxyAgentSetting, Set-AzVMssProxyAgentSetting as requested by this issue
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.