Skip to content

Conversation

@notyashhh
Copy link
Member

Description

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

@Copilot Copilot AI review requested due to automatic review settings October 16, 2025 05:08
@azure-client-tools-bot-prd
Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Azure PowerShell KeyVault module to use the latest 4.x version of the AutoRest PowerShell generator instead of the pinned 4.0.631 version, and regenerates the SDK accordingly.

Key Changes:

  • Updated AutoRest PowerShell generator version from 4.0.631 to 4.x
  • Regenerated the KeyVault Management SDK with the new generator version

@notyashhh notyashhh requested a review from isra-fel October 16, 2025 05:08
@notyashhh notyashhh changed the title [KeyVault] Use 4.x autorest/powershell version, Regenerated sdk [KeyVault] Use 4.x autorest version, Regenerated sdk Oct 16, 2025
/// set to true a unique x-ms-client-request-id value is generated and
/// included in each request. Default is true.
/// Whether a unique x-ms-client-request-id should be generated. When
/// /// set to true a unique x-ms-client-request-id value is generated and
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are double comments generated. I believe this is a known issue in autorest. So no problem for this sdk!

Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@isra-fel isra-fel merged commit 578b35a into main Oct 16, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants