Add XFF support to WAF custom rule #28730
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for X-Forwarded-For (XFF) header-based rate limiting variables to Azure Application Gateway WAF custom rules. The new variables enable rate limiting based on client IP addresses and geographic locations extracted from XFF headers, which is important for scenarios involving proxies or load balancers.
Key Changes
- Added two new VariableName options:
ClientAddrXFFHeaderandGeoLocationXFFHeaderto theNew-AzApplicationGatewayFirewallCustomRuleGroupByVariablecmdlet - Added comprehensive test coverage for the new XFF header variables, including creation and removal scenarios
Reviewed Changes
Copilot reviewed 5 out of 9 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| NewAzureApplicationGatewayFirewallCustomRuleGroupByVariableCommand.cs | Added validation for two new XFF-based variable names in the cmdlet parameter |
| New-AzApplicationGatewayFirewallCustomRuleGroupByVariable.md | Updated help documentation to include the new accepted values |
| ChangeLog.md | Documented the addition of the new variable names |
| ApplicationGatewayTests.ps1 | Added four test functions covering creation and removal scenarios for both new XFF variables |
| ApplicationGatewayTests.cs | Added test method declarations to invoke the new PowerShell test functions |
src/Network/Network.Test/ScenarioTests/ApplicationGatewayTests.ps1
Outdated
Show resolved
Hide resolved
src/Network/Network.Test/ScenarioTests/ApplicationGatewayTests.ps1
Outdated
Show resolved
Hide resolved
src/Network/Network.Test/ScenarioTests/ApplicationGatewayTests.ps1
Outdated
Show resolved
Hide resolved
src/Network/Network.Test/ScenarioTests/ApplicationGatewayTests.ps1
Outdated
Show resolved
Hide resolved
6 tasks
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
@yoavmal do you mind taking a look at the suggestions from Co-pilot to refactor. If not relevant/possible, please mark them as resolved with explanation. Cheers. |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
@DanielMicrosoft, code is refactored, and test runs are re-recorded. |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
DanielMicrosoft
approved these changes
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding XFF support to WAF custom rule.
This PR is a successor of this initial PR.
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.