Update Beaking change message for fd #28763
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…/azure-powershell into beaking-change-message-fd
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
There was a problem hiding this comment.
Pull Request Overview
This PR updates breaking change attribute messages across the FrontDoor module to correct inconsistent version references. The changes ensure that breaking change messages consistently use "15.0.0" for the deprecation version parameter instead of the previous "16.0.0" value that appeared in some README configuration entries.
Key Changes
- Updated breaking change attributes in C# cmdlet files to use consistent version parameters ("15.0.0" for deprecation version, "6.0.0" for module version)
- Added extensive breaking change configuration directives to the README.md file for AutoRest generation
- All changes affect breaking change metadata only - no functional code changes
Reviewed Changes
Copilot reviewed 31 out of 222 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| UpdateFrontDoorWafPolicy.cs | Added breaking change attributes for output type and parameters (EnabledState, Customrule, ManagedRule, LogScrubbingSetting) |
| SetFrontDoorRulesEngine.cs | Added breaking change attributes for output type and Rule parameter |
| SetFrontDoor.cs | Added breaking change attributes for output type and multiple parameters (RoutingRule, BackendPool, FrontendEndpoint, etc.) |
| NewFrontDoorWafRuleGroupOverrideObject.cs | Added breaking change attributes for output type and parameters (ManagedRuleOverride, Exclusion) |
| NewFrontDoorWafPolicy.cs | Added breaking change attributes for output type and parameters (EnabledState, Customrule, ManagedRule, LogScrubbingSetting) |
| NewFrontDoorWafManagedRuleOverrideObject.cs | Added breaking change attribute for output type and Exclusion parameter |
| NewFrontDoorWafManagedRuleObject.cs | Added breaking change attributes for output type and parameters (RuleGroupOverride, Exclusion) |
| NewFrontDoorWafManagedRuleExclusionObject.cs | Added breaking change attribute for output type |
| NewFrontDoorWafLogScrubbingSettingObject.cs | Added breaking change attributes for output type and ScrubbingRule parameter |
| NewFrontDoorWafCustomRuleObject.cs | Added breaking change attributes for output type and MatchCondition parameter |
| NewFrontDoorRulesEngineRuleObject.cs | Added breaking change attributes for output type and parameters (Action, MatchProcessingBehavior, MatchCondition) |
| NewFrontDoorRulesEngineMatchConditionObject.cs | Added breaking change attributes for output type and parameters (MatchVariable, Operator, Transform) |
| NewFrontDoorRulesEngineActionObject.cs | Added breaking change attributes for output type and parameters (RequestHeaderAction, ResponseHeaderAction, DynamicCompression) |
| NewFrontDoorRulesEngine.cs | Added breaking change attributes for output type and Rule parameter |
| NewFrontDoorRoutingRuleObject.cs | Added breaking change attributes for output type and parameters (AcceptedProtocol, DynamicCompression, EnabledState) |
| NewFrontDoorLoadBalancingSettingObject.cs | Added breaking change attribute for output type |
| NewFrontDoorHealthProbeSettingObject.cs | Added breaking change attributes for output type and parameters (Protocol, EnabledState) |
| NewFrontDoorHeaderActionObject.cs | Added breaking change attributes for output type and HeaderActionType parameter |
| NewFrontDoorFrontendEndpointObject.cs | Added breaking change attributes for output type and SessionAffinityEnabledState parameter |
| NewFrontDoorBackendPoolsSettingObject.cs | Added breaking change attributes for output type and EnforceCertificateNameCheck parameter |
| NewFrontDoorBackendPoolObject.cs | Added breaking change attributes for output type and Backend parameter |
| NewFrontDoorBackendObject.cs | Added breaking change attributes for output type and EnabledState parameter |
| NewFrontDoor.cs | Added breaking change attributes for output type and multiple parameters (RoutingRule, BackendPool, FrontendEndpoint, etc.) |
| GetFrontDoorWafPolicy.cs | Added breaking change attribute for output type |
| GetFrontDoorWafManagedRuleSetDefinition.cs | Added breaking change attribute for output type |
| GetFrontDoorRulesEngine.cs | Added breaking change attribute for output type |
| GetFrontDoorFrontendEndpoint.cs | Added breaking change attributes for output type and FrontDoorObject parameter |
| GetFrontDoor.cs | Added breaking change attribute for output type |
| EnableFrontDoorCustomDomainHttps.cs | Added breaking change attribute for output type |
| DisableFrontDoorCustomDomainHttps.cs | Added breaking change attribute for output type |
| FrontDoor.Management.Sdk/README.md | Added 967 lines of breaking change configuration directives for AutoRest code generation |
| /// <summary> | ||
| /// Defines the Get-AzFrontDoor cmdlet. | ||
| /// </summary> | ||
| [CmdletOutputBreakingChangeAttribute(typeof(PSFrontDoor), "15.0.0", "6.0.0", ReplacementCmdletOutputTypeName = "Microsoft.Azure.PowerShell.Cmdlets.FrontDoor.Models.IFrontDoor", ChangeDescription = "no longer has output type 'Microsoft.Azure.Commands.FrontDoor.Models.PSFrontend'.")] |
There was a problem hiding this comment.
Corrected spelling of 'PSFrontend' to 'PSFrontDoor' in the ChangeDescription to accurately reflect the deprecated type name.
Suggested change
| [CmdletOutputBreakingChangeAttribute(typeof(PSFrontDoor), "15.0.0", "6.0.0", ReplacementCmdletOutputTypeName = "Microsoft.Azure.PowerShell.Cmdlets.FrontDoor.Models.IFrontDoor", ChangeDescription = "no longer has output type 'Microsoft.Azure.Commands.FrontDoor.Models.PSFrontend'.")] | |
| [CmdletOutputBreakingChangeAttribute(typeof(PSFrontDoor), "15.0.0", "6.0.0", ReplacementCmdletOutputTypeName = "Microsoft.Azure.PowerShell.Cmdlets.FrontDoor.Models.IFrontDoor", ChangeDescription = "no longer has output type 'Microsoft.Azure.Commands.FrontDoor.Models.PSFrontDoor'.")] |
| /// <summary> | ||
| ///The Front Door object. | ||
| /// </summary> | ||
| [CmdletParameterBreakingChangeWithVersion("FrontDoorObject", "15.0.0", "6.0.0", OldParameterType = typeof(PSFrontDoor), NewParameterTypeName = "Microsoft.Azure.PowerShell.Cmdlets.FrontDoor.Models.IFrontDoorIdentity", ChangeDescription = "The element type for parameter 'RoutingRule' has been changed from 'Microsoft.Azure.Commands.FrontDoor.Models.PSRoutingRule' to 'Microsoft.Azure.PowerShell.Cmdlets.FrontDoor.Models.IRoutingRule'.")] |
There was a problem hiding this comment.
The ChangeDescription incorrectly refers to 'RoutingRule' parameter changes when it should describe changes to the 'FrontDoorObject' parameter. The description should match the parameter name specified in the attribute.
Suggested change
| [CmdletParameterBreakingChangeWithVersion("FrontDoorObject", "15.0.0", "6.0.0", OldParameterType = typeof(PSFrontDoor), NewParameterTypeName = "Microsoft.Azure.PowerShell.Cmdlets.FrontDoor.Models.IFrontDoorIdentity", ChangeDescription = "The element type for parameter 'RoutingRule' has been changed from 'Microsoft.Azure.Commands.FrontDoor.Models.PSRoutingRule' to 'Microsoft.Azure.PowerShell.Cmdlets.FrontDoor.Models.IRoutingRule'.")] | |
| [CmdletParameterBreakingChangeWithVersion("FrontDoorObject", "15.0.0", "6.0.0", OldParameterType = typeof(PSFrontDoor), NewParameterTypeName = "Microsoft.Azure.PowerShell.Cmdlets.FrontDoor.Models.IFrontDoorIdentity", ChangeDescription = "The element type for parameter 'FrontDoorObject' has been changed from 'Microsoft.Azure.Commands.FrontDoor.Models.PSFrontDoor' to 'Microsoft.Azure.PowerShell.Cmdlets.FrontDoor.Models.IFrontDoorIdentity'.")] |
isra-fel
added
the
Breaking Change Preannounce
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
isra-fel
approved these changes
Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.