Skip to content

Conversation

@VeryEarly
Copy link
Collaborator

Description

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

JoyerJin and others added 4 commits November 10, 2025 15:41
Co-authored-by: Yabo Hu <yabhu@microsoft.com>
)

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Yabo Hu <yabhu@microsoft.com>
Copilot AI review requested due to automatic review settings November 10, 2025 07:51
@azure-client-tools-bot-prd
Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements a major update to the Azure Monitor module, focusing on improving user experience and consistency while introducing breaking changes to AutoRest-generated projects. The changes involve:

  • Updating multiple AutoRest-based modules (ScheduledQueryRule, MonitorWorkspace, DiagnosticSetting, Autoscale) to use AutoRest v4.x instead of v3.x
  • Converting enum types to strings and collection types from arrays/single objects to List<T> for better forward compatibility
  • Adding new Update cmdlets for DiagnosticSetting and SubscriptionDiagnosticSetting
  • Adding new parameter sets with JsonFilePath and JsonString support for Create and Update operations
  • Regenerating documentation and help files
  • Adding breaking change exceptions to CSV files

Reviewed Changes

Copilot reviewed 113 out of 114 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tools/StaticAnalysis/Exceptions/Az.Monitor/BreakingChangeIssues.csv Documents breaking changes from the AutoRest update (121 new entries)
src/Monitor/ScheduledQueryRule.Autorest/README.md Removes AutoRest v3.x configuration and breaking change directives
src/Monitor/ScheduledQueryRule.Autorest/test/* Updates tests with new test data and adds Update cmdlet testing
src/Monitor/MonitorWorkspace.Autorest/README.md Removes AutoRest v3.x configuration
src/Monitor/DiagnosticSetting.Autorest/test/* Adds Update cmdlet tests and test recordings
src/Monitor/Monitor/help/* Updates help documentation for all changed cmdlets
src/Monitor/Monitor/ChangeLog.md Documents the breaking changes
Custom model cmdlet files Updates type signatures from enums to strings
Multiple documentation files Updates online URLs to lowercase format

@dolauli dolauli self-assigned this Nov 10, 2025
@dolauli dolauli merged commit 69cdf49 into main Nov 10, 2025
18 of 19 checks passed
@dolauli dolauli deleted the yabo/monitor branch November 10, 2025 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants