Skip to content

Conversation

@yifanz7
Copy link
Member

@yifanz7 yifanz7 commented Nov 13, 2025

Reverts #28772

Copilot AI review requested due to automatic review settings November 13, 2025 13:12
@azure-client-tools-bot-prd
Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

Copilot finished reviewing on behalf of yifanz7 November 13, 2025 13:15
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reverts Azure PowerShell PR #28772, which had added support for autoscale parameters, volume backup validation, and volume restore validation to the ElasticSan module. The revert removes these features and returns the module to its previous state.

Key changes:

  • Removes autoscale-related parameters (AutoScalePolicyEnforcement, CapacityUnitScaleUpLimitTiB, IncreaseCapacityUnitByTiB, UnusedSizeTiB) from New-AzElasticSan and Update-AzElasticSan
  • Removes two cmdlets: Test-AzElasticSanVolumeBackup and Test-AzElasticSanVolumeRestore
  • Reverts help documentation to use lowercase "update" and "create" in SYNOPSIS/DESCRIPTION sections
  • Updates test files to remove references to removed features
  • Reverts ChangeLog.md by removing the feature announcement entries

Reviewed Changes

Copilot reviewed 47 out of 54 changed files in this pull request and generated no comments.

Show a summary per file
File Description
Update-AzElasticSanVolume.md Reverted SYNOPSIS/DESCRIPTION capitalization from "Update" to "update"
Update-AzElasticSan.md Removed autoscale parameters documentation and reverted examples
Test-AzElasticSanVolumeRestore.md Deleted - cmdlet removed entirely
Test-AzElasticSanVolumeBackup.md Deleted - cmdlet removed entirely
New-AzElasticSanVolumeSnapshot.md Reverted SYNOPSIS/DESCRIPTION from "Create" to "create"
New-AzElasticSanVolume.md Reverted SYNOPSIS/DESCRIPTION from "Create" to "create"
New-AzElasticSan.md Removed autoscale parameters and reverted examples
Get-AzElasticSan.md Removed autoscale properties from example output
Az.ElasticSan.md Removed references to backup/restore cmdlets
ChangeLog.md Removed feature announcement entries for autoscale and backup/restore
Az.ElasticSan.psd1 Removed exported functions, updated version requirements, reverted formatting
ElasticSan.sln Updated project GUID reference
Test files Removed test cases for backup/restore, updated expectations, removed test environment variables

@notyashhh
Copy link
Member

@yifanz7 Hey What's this revert for? Was you feature merged to release branch?

@yifanz7
Copy link
Member Author

yifanz7 commented Nov 14, 2025

@yifanz7 Hey What's this revert for? Was you feature merged to release branch?

@notyashhh Yes the feature was merged for 11/18 release, but as the server is not ready, we'd like to have an OOB release to revert the feature. @dolauli should know the context, and mentioned we should merge this next week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants