Skip to content

Improved strategy cmdlets for VM and VMSS. #5722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Mar 14, 2018
Merged

Improved strategy cmdlets for VM and VMSS. #5722

merged 13 commits into from
Mar 14, 2018

Conversation

@sergey-shandar
Copy link
Contributor

@sergey-shandar sergey-shandar commented Mar 10, 2018 •
edited
Loading

Description

Improved strategy cmdlet.

Depends on PR #5716

Checklist

@sergey-shandar sergey-shandar mentioned this pull request Mar 10, 2018
Merged
8 tasks
markcowl
markcowl requested changes Mar 13, 2018
View reviewed changes
Copy link
Member

@markcowl markcowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor comment

...esourceManager/Compute/Commands.Compute/Manual/VirtualMachineScaleSetCreateOrUpdateMethod.cs Outdated
LoadBalancerName = LoadBalancerName ?? VMScaleSetName;
FrontendPoolName = FrontendPoolName ?? VMScaleSetName;
BackendPoolName = BackendPoolName ?? VMScaleSetName;
NewAzureRmVmss _Cmdlet { get; }
Copy link
Member

@markcowl markcowl Mar 13, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use _cmdlet

@markcowl markcowl removed their assignment Mar 13, 2018
@markcowl
Copy link
Member

markcowl commented Mar 13, 2018

one small requested change. On-demand run here: https://azuresdkci.westus2.cloudapp.azure.com/job/powershell-demand/602/

We will not need to run an on-demand run again.

@sergey-shandar sergey-shandar changed the title [Do NOT merge] Improved strategy cmdlets for VM and VMSS. Improved strategy cmdlets for VM and VMSS. Mar 13, 2018
@markcowl markcowl removed their assignment Mar 14, 2018
@markcowl
Copy link
Member

markcowl commented Mar 14, 2018

on demand run here: https://azuresdkci.westus2.cloudapp.azure.com/job/powershell-demand/603/

@cormacpayne cormacpayne merged commit 0670b24 into Azure:preview Mar 14, 2018
@sergey-shandar sergey-shandar deleted the sergey-strategy-upgrade branch March 14, 2018 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markcowl markcowl markcowl approved these changes

Assignees

No one assigned

Labels

Waiting for On Demand

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sergey-shandar @markcowl @cormacpayne