Skip to content

DSC extension refactored code for ARM & ASM #647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 33 commits into from Jul 30, 2015
Merged

DSC extension refactored code for ARM & ASM #647

merged 33 commits into from Jul 30, 2015

Conversation

@eshaparmar
Copy link
Contributor

@eshaparmar eshaparmar commented Jul 24, 2015

These changes mainly consist of refactored code that supports both ARM and ASM. We have moved a lot of common code for ARM/ASM at one place instead of writing it in two places.

eshaparmar and others added 29 commits June 11, 2015 13:10
@eshaparmar
Support for side by side module versioning
f910122
@eshaparmar
version conditions got swiped by mistake
e2e95e4
@eshaparmar
CR comments
783ab7a
@eshaparmar
Added format file for dsc get cmdlet in ARM
4e319ad
@eshaparmar
Merge branch 'dev' of https://github.com/dscsolutions/azure-powershell …
af44e43 
…into bugfixes
@eshaparmar
Merge branch 'armcmdlets-2.0' into bugfixes
d36f516
@narrieta
Fix storage suffix in ASM cmdlets
3e5d8f3
@narrieta
Merge branch 'armcmdlets' of https://github.com/dscsolutions/azure-po…
15cfa04 
…wershell into mooncake
@narrieta
Added storage suffix to ARM cmdlets
1c018ae
@eshaparmar
Move common code to commons
80f8a1e
@eshaparmar
Merge branch 'armcmdlets' into dev
817d3e0
@eshaparmar
more changes
23a7810
@narrieta
Merge branch 'dev' of https://github.com/dscsolutions/azure-powershell …
7c8f76c 
…into storage-suffix
@narrieta
Merge pull request #4 from dscsolutions/storage-suffix
3b5d5f6 
Fix Storage Endpoint Suffix
@eshaparmar
more changes
c9ebb91
@eshaparmar
renamed extensions folder and added vs proj settings
7ea546d
@eshaparmar
Correcting paths and vs proj file
d6c432b
@eshaparmar
Fixed the build issues
548a2ba
@eshaparmar
End to end publish ASM workflow
21930a7
@eshaparmar
Final refactoring for DSC code for ARM and ASM
384850b
@eshaparmar
Fixed resharper warnings from serialier class
c143ebe
@eshaparmar
Merge storage suffix changes from dscsolutions 'dev' to 'refactoring'
7c9083b
@eshaparmar
Removed public and private settings from get output format file
e0e431a
@eshaparmar
Making cmdlet base classes internal
bf25298
@eshaparmar
Changing methods to internal
973db34
@eshaparmar
Merge branch 'dev' of https://github.com/Azure/azure-powershell into …
8c4427c 
…refactoring

Conflicts:
	src/Common/Commands.Common/Properties/Resources.resx
@eshaparmar
Merge branch 'dev' of https://github.com/dscsolutions/azure-powershell …
9fae049 
…into dev

Conflicts:
	src/ResourceManager/Compute/Commands.Compute/Extension/DSC/PublishAzureVMDscConfigurationCommand.cs
	src/ResourceManager/Compute/Commands.Compute/Extension/DSC/SetAzureVMDscExtensionCommand.cs
	src/ResourceManager/Compute/Commands.Compute/Microsoft.Azure.Commands.Compute.dll-Help.xml
	src/ServiceManagement/Compute/Commands.ServiceManagement/IaaS/Extensions/DSC/PublishAzureVMDscConfiguration.cs
	src/ServiceManagement/Compute/Commands.ServiceManagement/IaaS/Extensions/DSC/SetAzureVMDscExtension.cs
	src/ServiceManagement/Compute/Commands.ServiceManagement/Microsoft.WindowsAzure.Commands.ServiceManagement.dll-Help.xml
@eshaparmar
Fixing merge conflicts
e27e3b8
@eshaparmar
Adding extension name and publisher to get/remove ASM cmdlets that go…
18b9182 
…t ommitted during refactoring
@azurecla
Copy link

azurecla commented Jul 24, 2015

Hi @eshaparmar, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!


It looks like you're working at Microsoft (esparmar). If you're full-time, we DON'T require a contribution license agreement.



If you are a vendor, or work for Microsoft Open Technologies, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

@hovsepm
Copy link
Contributor

hovsepm commented Jul 29, 2015

@azuresdkci add to whitelist

@stankovski
Copy link
Member

stankovski commented Jul 29, 2015

Started on demand test run - http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-on-demand/35/
Started MSI build - http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-msi/358/

stankovski
stankovski reviewed Jul 29, 2015
View reviewed changes
src/Common/Commands.Common/Commands.Common.csproj
Copy link
Member

@stankovski stankovski Jul 29, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you've added a new DLL to the output. Please regenerate WIX file if that is the case

Copy link
Contributor Author

@eshaparmar eshaparmar Jul 29, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure why we need to regenerate the wix file. We haven't added any new project/assembly. Just re-using an existing one(Microsoft.WindowsAzure.Management) and added it as a reference to the Command.Common project.

@stankovski
Copy link
Member

stankovski commented Jul 30, 2015

Started MSI build - http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-msi/362/

stankovski added a commit that referenced this pull request Jul 30, 2015
@stankovski
Merge pull request #647 from dscsolutions/dsc_release
cd9b53c 
DSC extension refactored code for ARM & ASM
@stankovski stankovski merged commit cd9b53c into Azure:dev Jul 30, 2015
@eshaparmar eshaparmar deleted the dsc_release branch August 4, 2015 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@eshaparmar @azurecla @hovsepm @stankovski @narrieta